Comments (4)
Hi @Tillaert,
Thanks for reporting this issue! docker-compose down
was not being used because this plugin was created before that command was available. In order to maintain compatibility with older versions and allow for some of the advanced debugging flags in the Plugin to continue to work such as composeRemoveContainersOnShutdown
I'm attempting to stick with docker-compose stop
for now. However, in the future I may switch over to using docker-compose down
instead.
I have released a 1.0.21-SNAPSHOT
version with PR #58 which should contain the functionality that you are looking for. It is similar to the PR you made except that it also prevents external networks from being removed, verifies that the network is in use before removing it, and also attempts to check for the default network.
Let me know if it works for you and I'll merge it into master.
resolvers += "Sonatype Snapshots" at "https://oss.sonatype.org/content/repositories/snapshots/"
addSbtPlugin("com.tapad" % "sbt-docker-compose" % "1.0.21-SNAPSHOT")
from sbt-docker-compose.
Quick question: Why is the plugin tyring to keep track of the running instances and stopping them? It seems that the plugin is reimplementing docker-compose functionality. Is it because the containers/networks should remain afterwards?
from sbt-docker-compose.
The current 1.0.21-SNAPSHOT indeed cleans up the networks 👍
from sbt-docker-compose.
Closing this issue out as there is now an official release that includes this update:
addSbtPlugin("com.tapad" % "sbt-docker-compose" % "1.0.21")
@Tillaert - Thanks again for your assistance.
from sbt-docker-compose.
Related Issues (20)
- Plugin starts tests even if not all containers are ready. HOT 4
- useStaticPorts does not seems to take effect HOT 2
- -debug doesn't work with specs2 HOT 2
- How to link my scala app's container, created by sbt-native-packager, to the dependency containers? HOT 1
- dockerComposeTest does not remove Docker instances when the compliation fails HOT 7
- multi project build with sbt-native-packager HOT 2
- DockerComposeTest does not pick up FeatureSpecs HOT 3
- Specs2 tests that have a different constructor don't run
- dockerComposeTest returns success on compilation error
- Provide dockerComposeTestOnly HOT 1
- Question - where does sbt-docker-compose plugin live? HOT 2
- Exception for invalid volume definition
- Configurable 'instanceName' (-p project-name)
- Forthcoming Deprecation / Transfer of Ownership Notice HOT 2
- SBT 1.3.3 breaks sbt-docker-compose
- dockerComposeTest doesn't include parent test scope in dependency classpath
- "Could not parse image id" HOT 1
- Support docker-compose 2.x HOT 3
- Run specs2 tests in multi-project code? HOT 4
- SBT 1.1.0-M1 compatibility issues HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sbt-docker-compose.