Coder Social home page Coder Social logo

Comments (5)

kurtkopchik avatar kurtkopchik commented on June 24, 2024 1

@dpfeiffer & @mb720 - I made an update to the plugin that allows it to now handle docker-compose environment variables that are defined using the ${VARIABLE:-default} format introduced in version 2.1.

If you do not define the environment variable value in the settings variablesForSubstitution or variablesForSubstitutionTask then the default value will be used.

This change has been published in 1.0.22-SNAPSHOT

resolvers += "Sonatype Snapshots" at "https://oss.sonatype.org/content/repositories/snapshots/"
addSbtPlugin("com.tapad" % "sbt-docker-compose" % "1.0.22-SNAPSHOT")

Let me know if you find any issues with it before I merge it to master. Apologies for the delay.

from sbt-docker-compose.

kurtkopchik avatar kurtkopchik commented on June 24, 2024

Hi @mb720! Very cool project.

So the way that environment variable substitution works with the sbt-docker-compose plugin is that you need to define the environment values (or a task that calculates the environment variable values) in your build.sbt file. The plug-in then substitutes these values in the compose file before passing it on to docker to process. For reference here is the PR that added this feature.

There is also an example project basic-variable-substitution showing how to use the variable substitution feature.

There are two build.sbt settings that can be used to configure environment values in the docker compose file:
variablesForSubstitution =: // A Map[String,String] of variables to substitute in your docker-compose file. These are substituted substituted by the plugin and not using environment variables.
variablesForSubstitutionTask =: // An sbt task that returns a Map[String,String] of variables to substitute in your docker-compose file. These are substituted by the plugin and not using environment variables.

That being said, looking at your example docker compose file, it looks like Docker introduced a new feature starting in the 2.1 version of the compose file format where you can provide a -default value to the environment variable definition:${VARIABLE:-default}

The current sbt-docker-compose plugin code does not handle this -default value setting at the moment and would have to be updated to support it. For now, you would have to use the standard ${VARIABLE} format and perform any default value logic in your build.sbt. It should be possible to make a code update to the plugin so that it knows how to read the new -default value when it exists and use it if nothing was explicitly provided for substitution. I'll have to look into adding this in the future.

I hope this helps!

from sbt-docker-compose.

dpfeiffer avatar dpfeiffer commented on June 24, 2024

@kurtkopchik Handling of the variable substitution default value is something I am as well looking forward to.

from sbt-docker-compose.

dpfeiffer avatar dpfeiffer commented on June 24, 2024

@kurtkopchik I will try it today

UDATE: Works fine for me.

from sbt-docker-compose.

kurtkopchik avatar kurtkopchik commented on June 24, 2024

@dpfeiffer - Thank you for verifying! The fix for this issue is now included in an official release:

addSbtPlugin("com.tapad" % "sbt-docker-compose" % "1.0.22")

from sbt-docker-compose.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.