Comments (6)
I tried a build with the changes on feature/dockerForMacSupport
and it seems to work.
from sbt-docker-compose.
Hi @michaelpigg, I'm glad you already found the feature/dockerForMacSupport
branch! We have some more testing to do on that branch but hope to integrate it into the master
branch soon for an official release. Let us know if you find any problems with it.
from sbt-docker-compose.
Please consider merging and releasing the dockerForMacSupport branch, the exported ip:port isn't very useful with docker for mac at the moment.
However, if somebody is using Alpine Linux via some boot2docker alternative or as a host OS, won't it mis-detect it as docker for mac, which would break the hostname for those users? I guess it's not that common though.
I don't know of the "proper" way to probe for docker for mac, so I'd suggest also adding a check for docker version --format '{{.Client.Os}}'
== darwin
, then you know that the client is running on OS X which should significantly increase the odds it's really docker for mac. Reference: https://docs.docker.com/engine/reference/commandline/version/
Also see discussions on fixing this issue in docker for mac itself, it's a known issue:
https://forums.docker.com/t/support-tap-interface-for-direct-container-access-incl-multi-host/17835/4
https://forums.docker.com/t/ip-routing-to-container/8424
from sbt-docker-compose.
Hi @stela - Thanks for pinging me on this issue and providing some links with your research. I had looked into this a while back myself and came up with an approach that appears to work but didn't get around to implementing the actual change until today.
The approach I took was to additionally validate that the Server.KernelVersion
ends in -moby
.
See the following thread for a bit of discussion on this:
http://stackoverflow.com/questions/38223965/how-can-i-detect-if-docker-for-mac-is-installed
I have merged these changes into the master
branch and published a new release:
addSbtPlugin("com.tapad" % "sbt-docker-compose" % "1.0.19")
Let me know if it works for you. Thanks again for the feedback and using the plug-in!
from sbt-docker-compose.
Works perfectly on my Mac using the System.getProperty("containername:portnr")
approach, thanks!
from sbt-docker-compose.
Great I'm glad that it's working as expected!
from sbt-docker-compose.
Related Issues (20)
- Plugin starts tests even if not all containers are ready. HOT 4
- useStaticPorts does not seems to take effect HOT 2
- -debug doesn't work with specs2 HOT 2
- How to link my scala app's container, created by sbt-native-packager, to the dependency containers? HOT 1
- dockerComposeTest does not remove Docker instances when the compliation fails HOT 7
- multi project build with sbt-native-packager HOT 2
- DockerComposeTest does not pick up FeatureSpecs HOT 3
- Specs2 tests that have a different constructor don't run
- dockerComposeTest returns success on compilation error
- Provide dockerComposeTestOnly HOT 1
- Question - where does sbt-docker-compose plugin live? HOT 2
- Exception for invalid volume definition
- Configurable 'instanceName' (-p project-name)
- Forthcoming Deprecation / Transfer of Ownership Notice HOT 2
- SBT 1.3.3 breaks sbt-docker-compose
- dockerComposeTest doesn't include parent test scope in dependency classpath
- "Could not parse image id" HOT 1
- Support docker-compose 2.x HOT 3
- Run specs2 tests in multi-project code? HOT 4
- SBT 1.1.0-M1 compatibility issues HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sbt-docker-compose.