tamb / object-bystring Goto Github PK

Write the code to be more legible.

I strongly suggest you work on your code's legibility. I assume you're a relatively junior developer.

Making code terse (almost "leetcode") might sound cool in principle, but it's incredibly hard to read. So, please name variables in a way that's clear what they are. Single-letter variables aren't helping with performance in any way and just make things harder.

s = s.toString().replace(/^./, ""); I get regex's are cool, but you could just do if (s[0] == '.') { s = s.slice(1); }. Much easier to read (many devs hate regexs) and possibly faster too

From reddit https://www.reddit.com/r/javascript/comments/d5zx65/wtf_wednesday_september_18_2019/f0sgsgc?utm_source=share&utm_medium=web2x

There's no attribution to the original source for the code.

I tried the demo attached to your readme. This works as expected, where when I provide an accessor I get it's associated value. The project available on NPM however, does not work this way.

Consider the following object:

{
    person: {
        name: "Joe",
        age: 33,
    }
}

Expected result for accessor person.name is Joe as a string. Actual result was an object like { name: Joe }.

Create UMD to not clutter the Object.prototype. This should simply export a utility method.
UMD utility : object-bystring/util
Polyfill: object-bystring

UMD should export polyfill in object and util by default.
THIS IS A BREAKING CHANGE.

end results should be

// default util
import byString from 'object-bystring';

// polyfill
import { byStringPolyfill } from 'object-bystring';