tam7t / hpkp

golang hpkp client library

Hi there 👋

• 🐶 Art is my passion
• 💬 Ask me about secret management, google cloud

hpkp's Issues

Seems not to work anymore - Even not the example

This seems to be broken. I've tried the github example and changed all of the Pins - should be invalid / throw error etc.

However it does not complain at all.

round tripper

an example round tripper that parses & adds headers to storage to learn pins

🔒emoji issues?

Pinning a grpc client

Hello there, this library is super cool for me, I don't know why doesn't have more starts :(

A little question: is possible to do pinning with a grpc client ?
There's a secure client for grpc here, but I got lost trying to make it fit with this lib, it looks like it's possible 'cause both handle the idea of tls.Configs in some points.

Other question, are you using this library in production ? I have used it for my toy projects, but now I have intentions to use it in a real project at work.

Thanks in advance!!

support "Public-Key-Pins-Report-Only"

https://tools.ietf.org/html/rfc7469#section-2.3.2

hpkp Dialer compatability with HTTP2

Trying to use your dialer against http2.Transport seems to fail
Looks like http2.Transport.DialTLS expects

type Transport struct {
...
DialTLS func(network, addr string, cfg *tls.Config) (net.Conn, error)

See: https://github.com/golang/net/blob/master/http2/transport.go

Where your DialTLS doesn't accept a tls.Config

https://github.com/tam7t/hpkp/blob/master/dialer.go

My Error:

./https.go:63: cannot use hpkpDialConf.NewDialer() (type func(string, string) (net.Conn, error)) as type func(string, string, *tls.Config) (net.Conn, error) in assignment

Code is here:
https://github.com/GinoM/dingo/tree/hpkp-pinning

Your code works fine against http.Transport though.

I feel like there is probably a better solution but maybe you can add something like

func (c *DialerConfig) NewDialer2() func(network, addr string, cfg *tls.Config) (net.Conn, error) {
        c.TLSConfig = cfg
	reporter := c.Reporter
	if reporter == nil {
		reporter = emptyReporter
	}

	return newPinDialer(c.Storage, reporter, c.PinOnly, c.TLSConfig)
}```

cmd tools returning null null

hpkp-headers https://github.com and any url that I try returns a "null \n null"

null result on OSX

I haven't debugged it, but this is what's happening with Go 1.17 on OSX:

❯ hpkp-headers https://github.com
null
null