talishar / talishar-fe Goto Github PK

Allow rematch, vote up, vote down etc.

schema Talishar/Talishar#164

https://youtu.be/bgROhfoeKJc?t=719

Not able to play bolt n shot from arsenal.

I think it's because it might have a different border colour / different play ability so need to implement logic for that.

discord suggestion link:
https://discord.com/channels/865412150125789214/971928581267664936/1055152342779039824

would it be possible when an attack is announced, the amount of damage it is threatening is stated on the screen? so when i am deciding instants i can see how much the attack is for

Some screens are bigger than others and we've had some ideas on how talishar should display, and where which item should go where, some people want bigger cards, some people like the focus on the chain link. I think can experiment and try a few different layouts and see what people think.

We've made a new way for cards to be inserted into strings using double curly braces {{ like this }}

Actually implement the decoding of it on the front end, so we can improve the whole gameplay log, and can get rid of the extra unneeded javascript to show a popup card from chat.

Border colour 2 needs to be implemented.

A scrollbar should appear underneath the permanents bar to indicate they can scroll left and right to select more stuff.

Ideally I would like it if little arrows could appear on the left and right.

Need to hook into the existing system that detects if a player is AFK.

https://discord.com/channels/865412150125789214/1038535956426407987/1058788137687597127

Return to main menu option not working in options menu.

https://discord.com/channels/865412150125789214/865423689976774656/1065425415105155072

Related to #27 - should have the buttons work to start with before building out the rest.

Chat should work. Hit enter or press a button to send a message

Add indicator for number of Blood Debt cards (both player and opponent).
Add popup showing list of blood debt cards.
Indicate if blood debt is active or not.

Cards that should be playable from banish should appear in-hand? I think? Who's still playing Chane?

The cognition nodes cannot be activated.

In the legacy client they can:

The item needs to be sent Action, actionDataOverride and borderColor params from BE so it can be rendered as active (and clickable).

Man Sant was nice enough to make a new Health + AP Widget to use. Get it implemented.

Card in banish doesn't have a border to indicate it's playable, but it is playable (which does work!). Could be a BE issue?...

https://discord.com/channels/865412150125789214/1038535956426407987/1062520745122607155

Need to implement end game screen / stats / rematch etc

Talishar/Talishar#133

Right now the UI scales properly on desktop and most laptop / ipad style devices.

It doesn't look very good on phones though.

I think the font size needs to scale up and down depending on the size of the screen. This could require a big rework of how elements are measured on screen.

I am considering a second vertical-first layout option. Ideally have some media query to switch between the two. Landscape orientation could be optimised for desktop, vertical layout optimised for mobile / small widdle screens.

Considering react-icons uses Game Icons as a source it shouldn't be too hard just to just swap where we can.
https://game-icons.net/

In particular we can use Tombstone as opposed to pirategrave as a less busy "graveyard" icon and a few other things too. Until we get our own custom artwork done for everything at least.

Make the turn tracker widget work as opposed to just being a block

It’s natural to drag the cards from hand to play them. Why not drag blocking eq to the combat chain too?
Or even drag your pistol when it’s playable to pew pew for two.

can also be handy for those cards in banish we want to play. Drag it over the play area n drop.

Eventually we will like to have customisable playmats, and some as patreon rewards like card backs.

For now we need a "plainer" playmat as some people say the current one is too distracting.

Could make the design a bit subdued like how Felt Table do theirs too. But right now maybe a plainer colour/texture is more appropriate.

Identical tokens should be stackable so you don't have 9 billion frostbites across the screen. Thanks, Denny.

Open the popup / modal when we try to view the currently active chain link and previous chain links.

Using rtk query to cache the response so we don't repeatedly hammer the server opening and closing windows a lot.

Historical chain link:
https://discord.com/channels/865412150125789214/1019632221335859361/1054919905490772039

We need to know if a card is faceup or facedown when it should or shouldn't be.

adding to Card JSON:

face:
enums:
UP = face up (all players can see)
DOWN = face down (opponent cannot see but player can see)
DOWNALL = face down to everybody ? (mystery card!)
null value = default for zone.

Got a better idea?

Right now when switching from new to old client, you're still logged into the old client, and can timeout from there. I found some naughty players claimed victory because the old client reported a timeout.

Anyway need to have a button in the options menu to switch back to the old FE before we do the same on the current FE.

Should have Blood Debt, Soul etc as a special counter type in GetNextTurn3.

Keep the current soul count as it is so we don't brick it.

But we can have a new one to track blood debt, if it's active or not. Just for the specific heroes it applies to.

Is there a special one for assassin?

Need a screen for the end of a game.

Needs to match all features the old UI has.

Incorporate react router so there are routes and can navigate about to pages.

Need to implement a way to lazy load or have card image placeholders while the high res version is beamed through the tubes to clients.

see image.

need to spend an hour or so just playing with the iPad in debug mode to iron these out.

I mean it just looks nasty when it happens.

In GetNextTurn3 we send player names.

We should have it set to show if someone is a patron and I can have the little heart on display next to their name.

For super flex we can have the talishar coin next to our names for devs, same as the chat.

Some users have web browsers that do not support CSS dvh property so they got jank happening like this:

https://discord.com/channels/865412150125789214/865423689976774656/1064447822784626728

https://discord.com/channels/865412150125789214/865412150125789217/1063694383871963146

We need to have vh as a fallback height option.

https://discord.com/channels/865412150125789214/971928581267664936/1054940838100213854
A little on hover tool-tip for the menu options would be nice to give it a quick read if one option suits my needs. Also Access to the menu from the home page not only in game. Integration of the deck stats via the profile page which looks kinda empty atm( one can dream )

Explainers for options seems like a good QOL improvement

I want to unify the modals & toasts to be one - or absolute max two - component(s), right now it's a bit of a mess with things everywhere showing different bits all relying on updates to the redux store.

In addition to modal windows popping up and staying on screen, I'd like it that toasts can appear for a short amount of time.

Short toasts can show things like die roll results, revealed cards, any announcement we want to do for downtime etc.

Etasus has offered to improve the cutouts for the small square versions of the cards.

This issue is to track them being completed and added to the new UI as well as ported to the old one.

9/10

when mulitiple could apply multiple effects on one card (preferably clarified on the section on the 'opponents effect' section) for cards such as voltaire

Mentions: 1

https://discord.com/channels/865412150125789214/971928581267664936/1018372140191469578

In production we’ve already got the servers configured to accept *.talishar.net as origins to prevent cross origin requests. Stopping CORS errors.

We still have CORS issue when in dev environment though, because we are always on the local host.

When the environment is dev I think all requests to either dev, beta, or production BE should go via a /api/env/ directory endpoint on the fe dev server, so the requests can then be proxied out to the appropriate env, and then would require us to have a horrible CORS bypass extension in our browser.

Add indicator saying how many cards are in soul.
Have popup showing list of cards in soul.
Have indicator telling if the hero has charged that turn or not. (similar to blood debt).

It looks pretty jank

I can’t navigate to the main menu if the options fails to load for the expired game.

See attached issue:
#153

Items are out of alignment and clip the parent div when they have a gem. D:

Add keyboard shortcuts aside from spacebar/pass.

Option 1) Keep same as current talishar
Option 2) Focus on wasd side of the keyboard

Advanced Option 3) have it customisable

The "cards fan" is a bit divisive and some people don't like it. Let's make it an option that is saved to the user's preferences. If they don't like it, it can default to the same view as if they're spectating.

Maybe no need to have the drag n drop on the spectator view. Can click and play.

Talishar/Talishar#58

Show both sides of DFC when you hover above the invocations (UPR009 -> UPR0017):
https://discord.com/channels/865412150125789214/971928581267664936/992124188661919866

Hook up the options menu so it works.

412595 - On new layout, it does not show what the card you look at on top in from Arakni's ability affect or any assassin effect.

Right now if a card is played by pressing on it with touch, the card pop up is still displayed, to clear it I need to touch elsewhere on the screen.

I think a show/hide button on the priority pop up windows could be very handy. So when Vis pops 18 runechants you can hide the window to look at the board before deciding what to do as an example

Mentions: 6

https://discord.com/channels/865412150125789214/971928581267664936/1017071410516086794

Some way to show temporary (or even permanent) buffs to weapons and cards is needed. Or even if a weapon just has some ability baked in like Boost/Go Again etc

This would make cards like Blood on Her Hands much easier to use because you can see which card already has Go Again etc.

This will require more info to be sent to the FE from the BE.

Talishar/Talishar#119