takafumir / rails_amp Goto Github PK

Is there support for AMP for ActionMailer?

Hi! I wanted to know how can I target inside rails_amp.yml to a controller inside a directory.

E.G. I want to target both controllers/posts_controller#show and controller/blog/posts_controller#show. I have tried the following but it seems not to be working:

targets:
  posts: show
  blog_posts: show 

Hi,

I'm having an issue when trying to access the AMP version of a Rails view in my local environement

What happens is :

• For a given url : http://localhost:3000/pages/my-action
• The AMP url is http://localhost:3000/pages/my-action.amp
• Going to this URL throws an error, because all the instance variables return nil
• My guess is, it might have something to do with the overriding of the controller actions that is done there : https://github.com/takafumir/rails_amp/blob/master/lib/rails_amp/overrider.rb#L16
• Some helpers also happen to be overridden in a weird way (ex: using number_with_delimiter) with AMP format returns an ArgumentError exception (wrong number of arguments, given 2, expected 0)

# app/controllers/pages_controller.rb
class PagesController < ApplicationController
  def my_action
    @my_instance_var = "some data"
  end
end

# app/views/pages/my_action.html.erb
<%= @my_instance_var %> #=> returns nil

Context :

• Bug happening on multipleRails projects, all of which version is 4.2.10
• Ruby version is 2.6.2

Any insights?

if using this gem with cloudinary gem, the cloudinary helper:

cl_image_tag (which is a wrapper to image_tag, used to create img tags with cloudinary parameters)

creates an infinite loop which throws:

SystemStackError (stack level too deep)

I am wondering if rails_amp works with Rails 5.1. If not, any plan to update it? Thank you.

To display article body, I use actiontext (0.1.0) in conjunction with activestorage (5.2.3).

I don't have amp-img tag substitution. The HTML code does not change for the AMP version of the site.

And I get errors in google search console.
How can this problem be solved?