taig / communicator Goto Github PK

Hi there,

This project looks pretty cool and simple and I'm attempting to use it in my Scala / Android project.
However, the documentation seems out of date, especially the .done callback which expects the Response.Payload class to be a class class which can be pattern matched whereas, it is a simple class.

Any chance of an updated README.md?

Thanks!

I struggle a bit on how to test code that uses Communicator, Ideally I’d create a Task[Response.With[String]] by hand in test and exchange it in tests, but the trait is sealed and the constructor is package private.

Instead of an abstract class the Event class should be an interface, allowing Scala to subclass it from a trait and implement method stubs. Thereby allowing to inherit from an activity or fragment instead of creating a dedicated inner class. For Java there needs to be an abstract class that implements the interface with stubs.

The Method.* API should be simplified to the effect that a Java call like GET( Parser.TEXT, new URL( "http://www.google.com/" ) ) could be executed as GET[String]( "http://www.google.com/" ) within Scala.

Monix has released a stable version in the 3.x series. It would be nice to move from the release candidate to the 3.1.0

I have made this PR #61 to help with this

Say, the response is a JSON which can be parsed to a student object:

case class Student(username: String, id: Int)

I want a Parser[Student] with parse method return a Task[Response[Student]]
How can I?

I'm unable to resolve Communicator as a dependency in sbt due to the following warning. Are the checksums corrupt?

problem while downloading module descriptor: http://repo1.maven.org/maven2/io/taig/communicator_2.11/2.0.2/communicator_2.11-2.0.2.pom: invalid sha1: expected=8bcb649e6bb835510a337dce76ffa340c933d26f computed=f8ed1419dd1bf3964d1143c4a376adcd75d360ee

I get the same error (with different checksums) when trying 2.0.1. However, 2.0.0 does work.