tadodotcom / grails-quick-search Goto Github PK

Is it possible to sort on multiple fields (firstName and lastName) so that "aa bb" comes before "aa cc" ?

Thanks a lot!

define nesting properties in searchProperties on Grails 3.2.11 > get rise error of class cast exception
I found the error cause in QuickSearchService line 238
def propertyQueryBuilder = { domainClass, property, String propertyAlias, String queryString ->
the propertyAlias is not always String.
remove the 'String' type solve the problem
I'll pull the fix

If I have a model with a User object like this:

class User {
    String firstName
    String lastName
}

and I want to be able to search for users called John Smith (firstName=John lastName=Smith), it would be cool if I could express that query using quick search. At the moment if I search for the string - John Smith, I retrieve all users with John in any field and all users with Smith in any field. I think in a lot of real world scenarios (especially those with complex models and large data sets), it quickly becomes hard to find what you're looking for.

Perhaps a good way to do it would be to assume that for any search term in quotes (e.g. "John Smith"), the tokens should be 'anded' together rather than 'ored'.

Would be really great to have a small example app

Specifying a sort column without it in the distinct columns causes H2 to fail as it will not sort on a column not in the results.

Setting the sort column as a distinct column in the query would be wrong as that would return the list of distinct values rather than the sorted domain objects.

If I try to use the customCriteria:

def customCriteria = { println it }

It prints an empty list: []

Is this a bug or am I using it wrong?

All code:

def searchParams = [sort: 'firstName', order: 'asc', max: MAX_SEARCH_RESULT, offset: offset * MAX_SEARCH_RESULT]
def searchProperties = [firstName: "firstName", lastName: "lastName"]
def customCriteria = { println it }
PagedResultList userList = (PagedResultList) quickSearchService.search(domainClass: User, searchParams: searchParams, searchProperties: searchProperties, query: query, customCriteria: customCriteria)

In a debugging attempt we found that the code is always going into this if: https://github.com/tadodotcom/grails-quick-search/blob/master/grails-app/services/org/grails/plugins/quickSearch/QuickSearchService.groovy#L186

Thanks for your help!

Hi

I see that customCriteria closure doesn't work. Inspecting the code I found that key of settings map is wrong: customClosure instead customCriteria.

Hi,

unfortunatly this probably great plugin has a very light documentation. An example how to use it would a lot more people try it out. Please consider to post an example of usage.

Best regards
-Bio

The totalCount property in QuickSearchService is incorrect - it is the total number of results with duplicates, whereas the results returned in the pagedResults collection has been filtered for duplicates.

This means that pagination is broken (the totalResults count is higher than the actual number of results returned).

Issue is about this line.

• A SimpleTemplateEngine.createTemplate method is called for every entry in the
  resultSet.
• For every such call, new class is created.

Goal is to reduce calls of SimpleTemplateEngine.createTemplate to the minimum.