Coder Social home page Coder Social logo

Comments (5)

TobiasBg avatar TobiasBg commented on July 2, 2024

Hi @Principia4834,

thanks for your work on this! I'll take a look as soon as possible, and I'll be more than happy to integrate this into TablePress directly if everything works fine!

Best wishes,
Tobias

from tablepress.

TobiasBg avatar TobiasBg commented on July 2, 2024

Hi @Principia4834,

I added such a feature (after some modifications to not break existing behavior) in commit 0074297.
Would be great if you could test this some more!

Best wishes,
Tobias

from tablepress.

TobiasBg avatar TobiasBg commented on July 2, 2024

Hi @Principia4834,

to add on, I added one more modification, in commit 8983b6e: As the table name is not unique, replacing of the table will only be done, if there was exactly one match of table name and file name. Otherwise (no matching table or more than one match), the file will be imported as a new table. This way, no possibly "wrong" tables will be replaced accidentally.

Regards,
Tobias

from tablepress.

Principia4834 avatar Principia4834 commented on July 2, 2024

Tobias
Thanks for the update. I have tested the new controller-admin.php on my Wordpress 5.6.2 site as follows:

  1. Import zip file with three files (book1.csv, book2,csv, book3.csv), option "Add as new table" - pass, new tables created
  2. Import zip file with three files (as above with extra line added to each), option "Replace existing table" - pass, existing tables updated
  3. Copy the table named book3.csv and edit the name so there are two identically named tables with different IDs. Import zip file with three files (as above with extra line added to each), option "Replace existing table" - pass, book1.csv and book2.csv are updated and new book3.csv table is created so preserving existing tables

So it all looks good to me.
Best wishes
Andy

from tablepress.

TobiasBg avatar TobiasBg commented on July 2, 2024

Hi @Principia4834,

great! Thanks for testing this! This confirms my tests, so that we can ship this, I think :-)

Best wishes,
Tobias

from tablepress.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.