Comments (5)
Hi @Principia4834,
thanks for your work on this! I'll take a look as soon as possible, and I'll be more than happy to integrate this into TablePress directly if everything works fine!
Best wishes,
Tobias
from tablepress.
Hi @Principia4834,
I added such a feature (after some modifications to not break existing behavior) in commit 0074297.
Would be great if you could test this some more!
Best wishes,
Tobias
from tablepress.
Hi @Principia4834,
to add on, I added one more modification, in commit 8983b6e: As the table name is not unique, replacing of the table will only be done, if there was exactly one match of table name and file name. Otherwise (no matching table or more than one match), the file will be imported as a new table. This way, no possibly "wrong" tables will be replaced accidentally.
Regards,
Tobias
from tablepress.
Tobias
Thanks for the update. I have tested the new controller-admin.php on my Wordpress 5.6.2 site as follows:
- Import zip file with three files (book1.csv, book2,csv, book3.csv), option "Add as new table" - pass, new tables created
- Import zip file with three files (as above with extra line added to each), option "Replace existing table" - pass, existing tables updated
- Copy the table named book3.csv and edit the name so there are two identically named tables with different IDs. Import zip file with three files (as above with extra line added to each), option "Replace existing table" - pass, book1.csv and book2.csv are updated and new book3.csv table is created so preserving existing tables
So it all looks good to me.
Best wishes
Andy
from tablepress.
Hi @Principia4834,
great! Thanks for testing this! This confirms my tests, so that we can ship this, I think :-)
Best wishes,
Tobias
from tablepress.
Related Issues (20)
- Replace jQuery.ready with window.onload HOT 3
- Have TablePress show pages a table is embedded on HOT 1
- Sorting issues with DD/MM/YYYY HOT 10
- Vanilla JS HOT 7
- Tablepress custom css not working HOT 1
- Add Custom Endpoint for TablePress tables using the WP REST API HOT 9
- Responsive Table extension is triggering datatables HOT 2
- column_default missing in TablePress_Editor_Button_Thickbox_List_Table HOT 4
- Editor page hangs browser when table has many rows (~1000) HOT 1
- Cross site scripting HOT 2
- Table cross the maximum size of template HOT 1
- Uncaught TypeError: can't access property "disabled", o(...) is null HOT 8
- Lesbarkeit von Beiträgen (Yoast SEO) wird durch einfügen der Tabelle von Gut auf OK runtergestuft HOT 2
- Question: posibility to get table information from a json REST api, instead of importing? HOT 4
- Can't save Auto Import Tables config HOT 1
- Function WP_Block_Type_Registry::register was called incorrectly HOT 2
- tablepress_rest_api:missing_capability:tablepress_edit_table HOT 7
- Help with translation HOT 3
- Freemius integration is doing heavy damage to wp_sitemeta meta_key fs_accounts HOT 5
- aria-role="link" in previous/next-buttons is redundant HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tablepress.