column_default missing in TablePress_Editor_Button_Thickbox_List_Table about tablepress

[TobiasBg]

Hi @maurocolella,

thanks for this suggestion! For consistency, this would indeed make sense.

Out of interest: What kind of meta data are you adding to the columns?

Regards,
Tobias

[maurocolella]

It's just a semantic annotation. Something indicating user groups (ie. This or that post belongs to one group or another).

…

On Sun, Feb 20, 2022 at 20:43 Tobias Bäthge ***@***.***> wrote: Hi @maurocolella <https://github.com/maurocolella>, thanks for this suggestion! For consistency, this would indeed make sense. Out of interest: What kind of meta data are you adding to the columns? Regards, Tobias — Reply to this email directly, view it on GitHub <#161 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFZ7NBFGTUFBAE6BJJVUETU4DOYTANCNFSM5O4BRH4A> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[maurocolella]

Might I suggest also adding this filter to the thickbox?

$data = apply_filters('tablepress_view_data', $view_data);

As:

public function handle_get_action_editor_button_thickbox() {
	TablePress::check_nonce( 'editor_button_thickbox' );

	if ( ! current_user_can( 'tablepress_list_tables' ) ) {
		wp_die( __( 'Sorry, you are not allowed to access this page.', 'default' ), 403 );
	}

	$view_data = array(
		// Load all table IDs without priming the post meta cache, as table options/visibility are not needed.
		'table_ids' => TablePress::$model_table->load_all( false ),
	);

	set_current_screen( 'tablepress_editor_button_thickbox' );

	/**
	 * Filter the data that is passed to the current TablePress View.
	 *
	 * @since 1.0.0
	 *
	 * @param array  $data   Data for the view.
	 * @param string $action The current action for the view.
	 */
	$view_data = apply_filters('tablepress_view_data', $view_data);

	// Prepare, initialize, and render the view.
	$this->view = TablePress::load_view( 'editor_button_thickbox', $view_data );
	$this->view->render();
}

[TobiasBg]

Hi,

sorry for the long delay on this!
A lot has happened around TablePress, and that Editor Button Thickbox will actually go away -- making this change obsolete. Please see https://tablepress.org/8-million-downloads-tablepress-2-0/ for the latest news :-)

Best wishes,
Tobias