t3-findit / findit Goto Github PK

The yellow warning when checking for a source file is a bit jarring when it's due to an interface.
Might be easily fixed with checking if the file starts with a captial I, for example IPrice, ISound, IShape...

Includes writing GoogleTests

Most likely needs quite a significant change to the StyleChecker to implement.

@NathanThus
Current style checker contains this:

    exceptionRegex = '(->)'

The latest style checker contains this (in the develop branch):

    exceptionRegex = '(->|\+\+|--)'

This could result in some annoying false positives when running the checker.

Style should be FILENAME_extension (H/HPP). Current style checker checks for FILE_NAME_extension. This causes problems with acronyms such as "TCP".

• Style Checker needs updating
• Doc needs updating

Bug location / Bug locatie

Other/Anders

Bug description / Bug beschrijving

When create a Docs/ PR it did not skip CI.

Steps to reproduce / Stappen om te reproduceren

Create a PR with capitalized name that does match the lower case regex.

Expected behavior / Verwacht gedrag

Skip CI even if capitalized.

Actual behavior / Werkelijk gedrag

Does not skip CI.

Additional information / Aanvullende informatie

No response

Contributing / Bijdragen

Yes / Ja

Feature location / Functielocatie

Master

Feature description / Functiebeschrijving

The master Item register needs to track the items in all of the nodes.
This could be achieved with an array of strings, though memory limits may apply.

Additional information / Aanvullende informatie

No response

Contributing / Bijdragen

Yes / Ja

Changed need to be merged into main branch to work.

Pull van develop naar jullie eigen branch om zo de .gitignore te updaten. Deze hebben jullie nodig zodra jullie bestanden gaan teovoegen.

includes:

• gezamelijke brainstorm
• MoSCoW

• .pio (libs are placed in here)
• TCPConnection.cpp (Basically a lib that was made by @TomVer99)
• TCPConnection.hpp (Basically a lib that was made by @TomVer99)

Bug location / Bug locatie

StyleChecker

Bug description / Bug beschrijving

Style checker geeft aan geen whitespace voor of na de = operator te zien. Terwijl dit wel het geval is.

Steps to reproduce / Stappen om te reproduceren

type in in je code:
if (queue.size() <= 0)

Expected behavior / Verwacht gedrag

dat het niet faalt

Actual behavior / Werkelijk gedrag

het faalt

Additional information / Aanvullende informatie

No response

Contributing / Bijdragen

Yes / Ja

DEADLINE: Sprint 4

Wi-Fi
I2C

to be reviewed by: Yassine

DEADLINE: Sprint 4

Wi-Fi

TODO:

• Database @TomVer99
• Message Structure @TomVer99
• Message Queue @Therealyassinetama
• User Interface @Therealyassinetama
• JSON parsing @TomVer99
• Apply TCP to use all other structures @TomVer99

klassen diagram
Sequence diagrammen

phase 1(Feedback Nathan):

• database
• draadloze communicatie met ardu/esp over TCP met JSON
• toevoegen, verwijderen, etc... items
• makkelijk kunnen inzien wat er globaal aanwezig is (UI?)

phase 2(Feedback Tom):

• vector toegevoegd voor de IPadressen van de verbonden clients
• IPadress en Port setters weggehaald en in de constructor gezet
• return types bij alle constructors weggehaald
• naam en id parameters aan object constructor toegevoegd
• protocol parser interface gemaakt
• relaties tussen klassen toegevoegd

phase 3(Feedback sioux):

• heel veel, screenshot op teams

final(Feedback Nathan + review Coen):

• interface tussen database en main

in het design zitten nog wat spelfoutjes en algemene foutjes, zoals:
IPadress veranderen naar std::string

Might be a good bit of research. This could be tested by creating a for loop that just communicates to the same device 255 times over I2C. This would allow us to test how long it takes to communicate to all the devices.

We could then draw a conclusion for polling or having the nodes take an active role.

DEADLINE: Sprint 4

This is a bug with the style checker

What will happen with the CAN POC branch / code? It is abandoned and won't be finished.

Documentation location / Documentatielocatie

Other/Anders

Documentation issue description / Beschrijving documentatieprobleem

Roles missing in main readme

Suggested documentation change / Voorgestelde documentatiewijziging

Add role description per team member in the main README

Additional information / Aanvullende informatie

No response

Specefiek -> Specifiek
Check het document