t0mcr8se / rif-identity-qr-payment-dapp Goto Github PK

Hey! Great submission. I have a few comments for the gitcoin hackathon:

Frontend

• Missing dependencies to run the app. I had to manually install @nuintun/qrcode
• Once running, there are multiple warnings about variables were created but not used. Please clean these up.
• Refactor some of the code for better readability.
  • Things like : for example,
  • move SVGs out of components or into their own components in some sort of /image folder

Backend

• npm install won’t run, I got a python error. This may be my machine, I'm unsure. Installing with yarn worked

If you have any questions about these, feel free to reply here, or come join us on the RSK Slack.