szmarczak / defer-to-connect

The safe way to handle the `connect` socket event

HTTP/1.1 418 I'm a teapot

defer-to-connect's Issues

Dropping support for node 8 should not be a minor update

I don't thinking dropping support for a major version of node (8) should only result in a minor revision update (i.e., from 1.1.0 to 1.1.2). This is causing "npm install" to start failing for our package because apparently some dependent packages use defer-to-connect.

Convert to TypeScript

Update dependencies

Include some tests

remove unnecessary files from npm package

Under some obscure ambiguous ava/eslint/lerna/typescript configuration, the tsconfig.json from this package ends up being parsed by the vscode eslint extensions.

This triggers a puzzling eslint parsing error (within vscode only) because of the rightfully missing dependency @sindresorhus/tsconfig

Possible workaround is to include @sindresorhus/tsconfig as a devDependency of the project where the issue occurs.

Another option could be to have the defer-to-connect npm package to only include the necessary files:

~/ref/defer-to-connect$ npm publish --dry-run

> [email protected] prepublishOnly .
> npm run build


> [email protected] build /Users/xxx/ref/defer-to-connect
> del-cli dist && tsc

npm notice
npm notice 📦  [email protected]
npm notice === Tarball Contents ===
npm notice 175B  .editorconfig
npm notice 1.1kB LICENSE
npm notice 1.5kB dist/index.js
npm notice 1.5kB package.json
npm notice 148B  tsconfig.json
npm notice 951B  README.md
npm notice 346B  dist/index.d.ts
npm notice 1.4kB source/index.ts
npm notice 3.8kB test.ts
npm notice 95B   .travis.yml
npm notice === Tarball Details ===
npm notice name:          defer-to-connect
npm notice version:       1.1.1
npm notice package size:  3.7 kB
npm notice unpacked size: 11.1 kB
npm notice shasum:        8fe78c004a940928c450b778563518d38b655a41
npm notice integrity:     sha512-aFmg/ZU3VEECH[...]O+NGxsXNrv9Lg==
npm notice total files:   10
npm notice
+ [email protected]

Possible options are:

• blacklisting through .npmignore
• whitelisting by adding "files": ["dist"] in package.json