Coder Social home page Coder Social logo

Comments (8)

funkyfuture avatar funkyfuture commented on June 4, 2024

The addition of the dependencies key in meta/main.yml with abbdafd broke my playbook.

i'm not convinced whether i want to use the referenced role as well. i see the point, but imo it's rather bloat given that i have to trust the repository's administrators anyway. (i configure https transport for apt packages in another role for all hosts.)

i'd rather prefer that this way of adding repos was an opt-in or had an opt-out for the sake of this role's reusability by the general public.

from ansible-role-jitsi-meet.

t2d avatar t2d commented on June 4, 2024

The addition of the dependencies key in meta/main.yml with abbdafd broke my playbook.

I'm sorry. What was the problem?

i'm not convinced whether i want to use the referenced role as well. i see the point, but imo it's rather bloat given that i have to trust the repository's administrators anyway. (i configure https transport for apt packages in another role for all hosts.)

That's true. It just limits how much you have to trust them. and it helps a bit agains stupidity ;)

What role to you use for https-transport?

i'd rather prefer that this way of adding repos was an opt-in or had an opt-out for the sake of this role's reusability by the general public.

I can see your point and would be open to accept a refactoring.

from ansible-role-jitsi-meet.

funkyfuture avatar funkyfuture commented on June 4, 2024

I'm sorry. What was the problem?

sorry, missed this:

ERROR! the role 'systemli.apt_repositories' was not found in ansible.legacy:/home/ansible_path/p/roles:/home/ansible_path/roles:/home/ansible_path/roles:/home/ansible_path/p

What role to you use for https-transport?

it's just one with various basic configurations. and i would argue that this configuration doesn't belong into one that facilitates the addition of a repo, as the name indicates.

I can see your point and would be open to accept a refactoring.

i see my responsibility for fixing things i broke… besides, it doesn't seem efficient to tackle a problem one hasn't dealt with yet.

from ansible-role-jitsi-meet.

t2d avatar t2d commented on June 4, 2024

To the best of my knowledge nothing is broken here.
Is there a conflict with other roles or do you just think it's bloated?

from ansible-role-jitsi-meet.

funkyfuture avatar funkyfuture commented on June 4, 2024

there's no conflict. after the cited error message in my previous post the play that includes this jitsi-meet role aborts.

from ansible-role-jitsi-meet.

t2d avatar t2d commented on June 4, 2024

Okay. Than just please install the missing role. It now described as a dependency in the README and ansible-galaxy install systemli.jitsi_meet would resolve this dependency automatically.

from ansible-role-jitsi-meet.

funkyfuture avatar funkyfuture commented on June 4, 2024

i'll have to check with my team whether we want to adopt the usage of Ansible Galaxy.

and as a thought, wouldn't it be better to improve the apt_repo task module w/ the goals that other role wants to accomplish?

from ansible-role-jitsi-meet.

funkyfuture avatar funkyfuture commented on June 4, 2024

fwiw, though it doesn't technically belong here, i want to share some feedback with you.

we decided to not adopt Ansible Galaxy. also, i'm as well experiencing a lot of effort when it comes to managing the different branches that are used for PRs and one for actual deployments. hence we also agreed to persistently rely on a fork of this repo and i will probably not propose further changes.

beside the required effort, it seems that different paradigms regarding configuration and role design are an obstacle to find a common ground. speaking from my perspective, you seem to prefer the bloaty whereas i tend to the less-is-more. but i haven't any other experiences with contributing to Ansible roles, so i dunno whether and how (far) it's possible to find a design that fits as much contexts and needs as possible.

from ansible-role-jitsi-meet.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.