synvox / rehook Goto Github PK

So you may want to update your readme.

following warning is rising when using withState and with withHandlers:

React Hook useMemo has a missing dependency: 'props'. Either include it or remove the dependency array  react-hooks/exhaustive-deps

why the code does not pass props as dependency?

 useMemo(() => initialState(props), [props])

I have optimized withHandlers like this

const withHandlers = handlers => (props: any = {}) => {
  const realHandlers = React.useMemo(
    () => (typeof handlers === "function" ? handlers(props) : handlers),
    []
  )

  const [state] = React.useState(() => {
    const store: any = {}
    store.cachedProps = props
    store.handlers = Object.keys(realHandlers).reduce(
      (acc: {}, key) => ({
        ...acc,
        [key]: (...payload) => realHandlers[key](store.cachedProps)(...payload)
      }),
      {}
    )
    return store
  })

  state.cachedProps = props

  return { ...props, ...state.handlers }
}

The "Smart/Presentational Components" section of readme says that pipe(withProps({}), Component) is a supported use case.

The implementation of pipe() is concise and elegant. Unfortunately it doesn’t work when the supplied Component was created by e.g. React.forwardRef() and thus is not a function but an object.

Could you add support for such components as well?

I actually had thought of starting a project like this when I saw the announcement that Recompose is being discontinued. We use Recompose heavily at my company and while I love the idea of the hooks proposal, we have a ton of Recompose in our apps that can not be easily converted to hooks, so I see something like this as a path forward. I'm curious if you have any ideas about what your biggest needs are for contributions, whether that's getting more parity with Recompose, needing more documentation, examples, tests, code, Flow and Typescript typings, etc...

Whatever you feel like your needs might be, I would love to jump in and start helping out because I see this project as exactly what we need going forward.

Would this be a welcome addition?

There is no github link to this package on the npm package page - https://www.npmjs.com/package/@synvox/rehook

Also, i really like the ideas and direction of this package!