synrc / rt Goto Github PK

@5HT How one can use this ets.erl NIF based module and avoid conflict with ets.erl shipped with the VM? Could you please provide an example usage?
Many thanks

You cannot spawn a process without a link within the function start_link. It could be very confusing and misleading

https://github.com/erlang/otp/blob/34b56e8f566c6f1aa6023bb7b4096b8f2d709d9e/lib/kernel/src/heart.erl#L229-L304

Should be replaced by gen_server I believe

https://github.com/erlang/otp/blob/34b56e8f566c6f1aa6023bb7b4096b8f2d709d9e/lib/kernel/src/application.erl#L229-L233

Should be moved to function guard

permit(_Application, Bool) when !is_boolean(Bool)
    exit({badarg, {?MODULE, permit, [Application, Bad]}});
permit(Application, Bool)
   ...

And we can do even better

permit(_Application, Bool) when is_boolean(Bool)
    ...

https://github.com/erlang/otp/blob/34b56e8f566c6f1aa6023bb7b4096b8f2d709d9e/lib/kernel/src/ram_file.erl#L135-L162

1. Copy-paste is considered to be code smell
2. Calling GC while reading file can cause unpredictable latency

https://github.com/erlang/otp/blob/34b56e8f566c6f1aa6023bb7b4096b8f2d709d9e/lib/kernel/src/user.erl#L450-L535

85 lines
4 levels case nesting (more than once)

Consider refactoring

It's almost logicless module. just a supervisor configuration. Pure data can be moved out to hrl-files or some configuration files

https://github.com/erlang/otp/blob/34b56e8f566c6f1aa6023bb7b4096b8f2d709d9e/lib/kernel/src/disk_log.erl#L1876-L1884

Reply isn't accumulated in foldl. Thus ok is returned if there were any successful req

<function>(S) ->
    case inet_db:lookup_socket(S) of
	{ok, Mod} ->
	    Mod:<function>(S);
	Error ->
	    Error
    end.

This pattern repeats itself all over the place. It can be replaced by a macro or a higher order function

These modules form a very basis of OTP and also a main selling point. Wishing freedom of supervisor implentation and legacy-free API I propose to introduce in new kernel and stdlib applications app and sup modules for Application and Supervisior. While implementing application and supervisor will be based on wrapping of all calls to app and sup core modules in new runtime.

https://github.com/erlang/otp/blob/34b56e8f566c6f1aa6023bb7b4096b8f2d709d9e/lib/kernel/src/application_controller.erl#L691-L792

That's not okay either.