symmetryinvestments / clrbridge Goto Github PK

The tryArrayBuilderFinish functions in clrbridge/package.d are causing a segfault in LDC. I've filed an issue here: ldc-developers/ldc#3314

When trying to execute the step rund example.d while building the project with command rund minish.d cleanBuildAll, tons of error spawned saying Error 1: Previous Definition Different {Mangled Name Here}.

After reading the codegen source code. I found that currently clrbridge lacks of a way to handle different overloads with only non-primitive parameters have different type.

For example, for Marshal.ReadInt64, both of its two-parameter overloads become ReadInt64(__d.clr.DotNetObject, int). Thus a case of the above mentioned Error 1 occurred.

Could there be a way to identify and fix this issue?

A possible way to solve this is to generate DotNetObject_IntPtr for C# IntPtr, DotNetObject_Object for C# Object and alias this each of these DotNetObject_??? to DotNetObject so that the line __d.globalClrBridge.box!"Object" could leave unchanged.

e.g.:
ReadInt64(IntPtr, Int32) -> ReadInt64(__d.clr.DotNetObject_IntPtr, int)
ReadInt64(Object, Int32) -> ReadInt64(__d.clr.DotNetObject_Object, int)

Also worth mentioning, as you may know, not everything in C# derives from object. So, although I haven't tested this by myself, try calling some String Constructors (and other methods with pointer-type or TypedReference parameters) may cause error or unexpected behaviour, thus need to be excluded from codegen procedure.

PS. may I ask what license is applied to this project?