[Notifier] Use new Emoji Component about symfony

[smnandre]

I'm not sure to follow.. the result would be the same right ?

[seb-jean]

Yes, the result would be the same. But is it better to use shortcode than directly emoji in the code? Is this a good practice? Or is it useless and we leave the emoji in the code?

[smnandre]

In my mind I really don't see why we would need some back and forth with a library to... get the exact same data in the end 😅

But instead using the Emoji component here would require multiple composer packages and a .... certain amount of emoji names translated in every possible variant ...

---

Regarding "good practices" i have no idea, but.. I let you guess this comparaison before clicking on the results ;)

<?php

echo mb_strlen('🐘') . PHP_EOL;
echo strlen('🐘') . PHP_EOL;
echo PHP_EOL;

echo mb_strlen(':elephant:') . PHP_EOL;
echo strlen(':elephant:') . PHP_EOL;
echo PHP_EOL;

Results: https://3v4l.org/dk4RV#v8.3.8

(note: i post this comparaison just for fun... IRL this difference makes in fact no impact here. and i don't mean "very few" i really mean "no")

[smnandre]

I checked by curiosity: these emojis are here since the component introduction

symfony/src/Symfony/Component/Notifier/Notification/Notification.php

Line 166 in 7f97a3f

protected function getDefaultEmoji(): string