BC Break when serializing an entity with an empty array in serializer_groups about symfony

[xabbuh]

Maybe related to #56875? Does the fix proposed for that one help here too?

[jderusse]

Maybe related to #56875? Does the fix proposed for that one help here too?

This is not related.

Here is simplified change in the implementation: (I removed the logic about isIgnored and wildcard groups)

https://github.com/symfony/symfony/pull/51514/files#diff-8183be74478a13fcda2e17124d559a29013d10f119805a6623a8a396edb70c76R48

foreach ($properties as $property) {
  if (null === $groups || array_intersect($groups, $property->getGroups())) {
    yield $property;
  }
}

note: array_intersect([], $property->getGroups()) returns nothing, that's why in previous implementation the list of properties was empty when the groups was [].

new implementation

$groups ??= [];
$groupsHasBeenDefined = [] !== $groups;

foreach ($properties as $property) {
  if (!$groupsHasBeenDefined || array_intersect($groups, $property->getGroups())) {
    yield $property;
  }
}

So all properties are included:

• before: When groups is null
• after: When groups is an empty [] (null is converted to [])

I can open a PR, I was just wondering if the initial behavior was expected or a bug