symblai / symbl-chime-adapter Goto Github PK

I'm submitting a ...
[ ] bug report
[X] feature request
[ ] question about the decisions made in the repository
[ ] question about how to use this project

Summary

Would like to see overloaded constructors to allow for passing in an existing stream, as well as a constructor that allows passing in a device ID. Currently, if Chime is using device A and device B is the default, symbl-chime-adapter will listen on device B which Chime is listening on device A. This is also part of the problem with releasing devices -- Chime releases the device it is using, but Symbl does not release its device. If I were to just pass in the stream, Chime killing its device means Symbl wouldn't need to worry about it.

Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

I'm submitting a ...
[X] bug report
[ ] feature request
[ ] question about the decisions made in the repository
[ ] question about how to use this project

Summary

When using this package as it exists on NPM, when calling close(), the media streams that were requested are not closed, and the application continues to use the provided audio source.

Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)