symbiote / silverstripe-datachange-tracker Goto Github PK

We have extended the manymany to achieve this...

http://www.silverstripe.org/community/forums/general-questions/show/75365

While this is probably OK to assume for nearly all cases, there could exist a situation where an ID of 500 is more recent than an ID of 1000.

The query should instead just delete records prior to the pruneBefore value. This would require the Created column in the DataChangeRecord table have an index applied to it.

I'll knock up a PR for review, at some point.

Would it be possible to add a few extra fields to search on, like Modification Date and User?

The 'Published States' gridfield only checks ClassID so can sometimes display objects that have colliding IDs.

https://github.com/silverstripe-australia/silverstripe-datachange-tracker/blob/master/code/extensions/SiteTreeChangeRecordable.php#L22

I am tracking a Varchar and a Boolean.

Subsite:
  significant_fields:
   - MyVarcharField
   - MyBooleanField
  extensions:
   - ChangeRecordable
   - SignificantChangeRecordable

I see the list of change records, but clicking to view details, I receive this error:

Object of class DataChangeTrackService could not be converted to string...

https://www.dropbox.com/s/6wh82awrq7iurze/Screenshot%202015-11-22%2010.45.06.png?dl=0

Should there be a callback for non-text fields? or is it a Casting or forTemplate issue?

Tring to install and it does not work. I get this error:
Fatal error: Uncaught Symfony\Component\Yaml\Exception\ParseException: The reserved indicator "%" cannot start a plain scalar; you need to quote the scalar at line 6 (near "dataChangeTrackService: %$DataChangeTrackService"). in \vendor\symfony\yaml\Inline.php on line 307

It looks like you need to wrap any % signs in yml files in quotes.

So something like this:

---
Name: datachange_injector_config
---
SilverStripe\Core\Injector\Injector:
  DataChangeTrackService:
    class: \Symbiote\DataChange\Service\DataChangeTrackService
  Symbiote\DataChange\Extension\ChangeRecordable:
    properties:
      dataChangeTrackService: '%$DataChangeTrackService'
  Symbiote\DataChange\Extension\SiteTreeChangeRecordable:
    properties:
      dataChangeTrackService: '%$DataChangeTrackService'

Can you quickly fix it up please :)

TrackedManyManyList breaks Member_GroupSet as it injects over it.

Hello

It seems when I change fields on a page and publish, the "Before" and "After" fields on the generated DataChangeRecord is always set to "null". And the ChangeType is always "Publish Stage to Live".

If I remove ChangeRecordable::onBeforeVersionedPublish() it all works as intended, change type is "Change" and before & after are correctly written.

I havent had time to debug this properly, just wanted to let you know