symbiote / silverstripe-base Goto Github PK

I have raised a pr with an updated favicon:)

It looks like at some point silverstripe/asset-admin has been fully spun out of both Framework and CMS.
If we are not going to use one of the SilverStripe recipes for included SilverStripe we'll need to add it into the composer.json.

Currently the default installed version is SS 3.5

Need to update build.xml to the following.
When our CI systems are building, they should then use ni_build flags.
(ni_build does things like create the silverstripe-cache folder as well)

<property name="composer.dev" value="" />
<property name="composer.source" value="--prefer-source" />
<if>
	<isset property="composer_dist" />
	<then>
		<property name="composer.source" value="--prefer-dist" override="true" />
	</then>
</if>
<if>
	<!-- Non-Interactive Build, ie. For CI -->
	<isset property="ni_build" />
	<then>
		<property name="composer.source" value="--prefer-dist --no-interaction --no-progress --no-suggest --optimize-autoloader --verbose --profile" override="true" />
	</then>
</if>

When using globally installed composer dependencies, projects will fail to find the PHPUnit path which will prevent SilverStripe from building. This is specifically an issue for a CI environment.

The workaround is to add this to the template file that is sourced during the build setup;

include_once 'PHPUnit/Autoload.php';

Currently master is one commit ahead of the current tagged release, however that commit includes the change to bundling in the docker set up Symbiote is now using.

From a quick glance it looks like a minor level change in SemVer terms, as removing or ignoring the files isn't going to break anything.

Opinions?

via @ajshort

.htaccess, .gitignore and _ss_env are completely overridden

_ss_env should not be created if a flag is passed (or a parent dir has an _ss_env file).

Sqlite3 module issue: Polymorphic database fields are bad news for reconstruction

We should remove this module from base until it is updated to solve issue 45. The error is subtle and extremely hard to debug, which makes it a developer time sink.

As per symbiote/silverstripe-build#34 and https://docs.silverstripe.org/en/4/changelogs/4.2.0/#app-folder-name, we should be renaming mysite to app. Thanks to the PR above, this should now be possible given hard coded references no longer exist. The main issue that jumps out here is our reliance on scripts under mysite and how we handle this moving forwards.

The problem

• SilverStripe\View\SSViewer::theme is deprecated. It's a bit confusing figuring out how to use the non-deprecated form. An example exists below. (ie. themes)
• SS4 defaults for MySQL aren't using our in-house standard.

The solution

SilverStripe\Core\Manifest\ModuleManifest:
  project: mysite
SilverStripe\View\SSViewer:
  themes:
    - simple
    - '$default'
  theme_enabled: true
Symbiote\Multisites\Model\Site:
  available_themes:
    - simple
---
Name: mysite-db
---
SilverStripe\ORM\Connect\MySQLDatabase:
  connection_charset: utf8mb4
  connection_collation: utf8mb4_unicode_ci
  charset: utf8mb4
  collation: utf8mb4_unicode_ci