syfschydea / ch-keys-to-lyrics Goto Github PK

There are various regexes which are used repeatedly in this script. These should be compiled

Currently, it is hard coded that lyric timing is read from the expert keyboard chart. There should be an option parameter (eg. --chart/-c) to specify which instrument and difficulty to read data from. This is mostly in case anyone wants to add lyrics to a song which already has an actual keyboard chart.

Currently, an error will occur if there is no events section. Some research should be done into what Moonscraper produces if there are no section names or any other events. If it just produces an empty events section, rather than an absent one, then this probably isn't really an issue.

Currently, input is always taken from stdin, and output is always written to stdout. It would be more user friendly to provide options to pass filenames as input and output files.
If two filenames are given, they should be taken to mean an input file, and an output file.
If one filename is given, this file should be modified in place, leaving a backup file in ".bak"
If no filenames are given, IO should be done through stdin and stdout as it is currently.

Currently, lyric events are created empty, with the expectation that the user will then go through again, adding the lyrics. This process would be made much easier by allowing the lyrics to passed in via a file.
This file should contain one line of lyrics per line, and any polysyllabic words separated by dashes. eg.

Just wan-na be
wan-na be-witch you in the moon-light