swipestripe / silverstripe-swipestripe-coupon Goto Github PK

Several of the fields are looped using the control tag which is deprecated in 3.1 - simply replacing these with loop resolves the problem

When applying a discount... discount is applied to shipping cost also.
Don't think that's correct. Shipping should be added AFTER the discount.

When you create a new Coupon you can't insert a decimal number.

give error that isn't a number and only numbers can be added

After fixing the control tags I then get an error indicating that the file CheckoutFormOrder.ss cannot be found in my theme. It is included from OrderForm.ss

./swipestripe-coupon/templates/Includes/OrderForm.ss:56:            <% include CheckoutFormOrder %>

Hi,

I have trouble with the $order->updateModifications() function. After doing couple debugs, I found the problem.

In https://github.com/frankmullenger/silverstripe-swipestripe/blob/2.1/code/order/Order.php#L717

$order calls the modification class like $modification->add($this, $value);

But in https://github.com/frankmullenger/silverstripe-swipestripe-coupon/blob/2.1/code/CouponModification.php#L17

when the modification object try to add the coupon into order, it gets Code data from '$order->CouponCode' instead of '$value'.

So every time the order got updated, all coupon modification data will be gone because it can't find the correct coupon code.

I hope this makes sense.