svix / rust-ksuid Goto Github PK

Feature Request

Motivation

I would like to use ksuid within an HashMap<Ksuid/KsuidMs, T> and I would prefer not to convert to a string, i.e. HashMap<String, T>.

Right now I am wrapping it within a struct (I am not aware of a better way, like a macro to implicitly call to_string before hashing):

use std::hash::{Hash, Hasher};
use svix_ksuid::Ksuid;

pub struct Id(pub Ksuid);

impl Hash for Id {
    fn hash<H: Hasher>(&self, state: &mut H) {
        self.0.to_string().hash(state);
    }
}

Proposal

I believe the following would be enough:

use std::hash::{Hash, Hasher};

impl Hash for Ksuid {
    fn hash<H: Hasher>(&self, state: &mut H) {
        self.to_string().hash(state);
    }
}

impl Hash for KsuidMs {
    fn hash<H: Hasher>(&self, state: &mut H) {
        self.to_string().hash(state);
    }
}

Pros:

• simple
• not prone to bugs or hash collisions (not more than ksuid as far as my understanding)

Alternatives

Having an intermediate String before computing the hash is not the most efficient way to do this but I personally would prefer to have something even if it is not the most performant 😇

Next

If you don't mind my proposal, would you like me to make a PR with it?

If you do mind adding this, fair enough, I will handle this on my end. 😉

If you do mind using the intermediate string, do you already have in mind a way to do it or would you like me to look into it? (my experience is limited)

Either way, thank you for the library 😄

Bug Report

The docs say there should be a feature enabling serde support but cargo complains that there is no such feature.
I can't really tell if this has been removed or added as a permanent feature that's always on?

Version

svix-ksuid v0.6.0

Platform

Linux antiva 6.1.12-1-MANJARO #1 SMP PREEMPT_DYNAMIC Tue Feb 14 21:59:10 UTC 2023 x86_64 GNU/Linux

Description

Trying to add the crate ends up with:

git:(main) cargo add svix-ksuid --features serde                         
    Updating crates.io index
      Adding svix-ksuid v0.6.0 to dependencies.
error: unrecognized feature for crate svix-ksuid: serde
no features available for crate svix-ksuid

Hi! I noticed you're using the chrono crate instead of the time crate, and I just wanted to make sure you are aware of the security and maintenance problems of chrono. The following couple of reddit threads are a good summary:

• Is the chrono crate unmaintained?
• Six weeks in, how are folks handling the time/chrono RUSTSEC advisories?

Feature Request

Motivation

Hi! I'm not sure if this is intentional, but it looks like Ksuid doesn't implement Display.
This means that to print it out you need to do format!("{}", ksuid.to_string()) rather than just format!("{}", ksuid).
Not a big deal, but adds some verbosity.

Proposal

Implementing Display should be as simple as moving the existing to_string logic into a Display impl.
I'm not sure if the type doesn't implement Display intentionally though. Perhaps this was done to avoid some API guarantees?

Alternatives

N/A