Comments (8)
To make sure I understand: the solution would be to force all tests to use the headers from the build directory, right?
from dagmc.
To make sure I understand: the solution would be to force all tests to use the headers from the build directory, right?
That would be my proposal, yes. I haven't looked at the CMake files, but I don't expect it would be a big change.
from dagmc.
One way to do this is by adding the build directory to the include path before the installation directory.
include_directories(${CMAKE_BINARY_DIR}/src/dagmc ${CMAKE_INSTALL_INCLUDEDIR})
Or, we can modify the tests themselves.
#include "${CMAKE_BINARY_DIR}/src/dagmc/DagMC.hpp"
from dagmc.
What if we add SET(CMAKE_INCLUDE_DIRECTORES_BEFORE ON)
?
Seems like a big hammer, and surprised we haven't encountered it before, but should work?
from dagmc.
What if we add
SET(CMAKE_INCLUDE_DIRECTORES_BEFORE ON)
?Seems like a big hammer, and surprised we haven't encountered it before, but should work?
According to my knowledge, DAGMC depends on third-party libraries installed in the system include directories. So, if these libraries have conflicting versions or headers with DAGMC, this could lead to unexpected behavior or compilation errors. However, we can resolve that by testing DAGMC in different build environments (Geant4, OpenMC, PyNE etc) to ensure that it works as expected.
from dagmc.
But for the purpose of testing we probably always want the most local headers, right?
from dagmc.
But for the purpose of testing we probably always want the most local headers, right?
Yes, it is usually best to use the most local headers to ensure that the tests are using the correct version of the code.
Setting CMAKE_INCLUDE_DIRECTORIES_BEFORE
to ON
can be one way to achieve this, but as I mentioned earlier, it can have unintended consequences if not used carefully.
from dagmc.
Related Issues (20)
- Remove need for downstream codes to have Eigen3 installed HOT 1
- False positive for assignment of vacuum HOT 7
- Making use of DAGMC in python package HOT 1
- error building when make DAGMC with MCNP6_BETA2 version HOT 3
- request to moving location of Dockerfile HOT 10
- UWUW Unit Test Failure HOT 3
- Improve documentation on OpenMC material assignment
- Update Pyne submodule
- Allow failures of builds using MOAB `master` and `develop` branches. HOT 1
- Update Pyne submodule
- Miscellaneous typos in documentation
- Control GeomQueryTool screen output HOT 12
- DAGMC not compatible with Geant4 v11.1.1 HOT 2
- DBUILD_MW_REG_TESTS requires h5m models that can't be found as URL missing HOT 9
- Add information on representation of metadata and topological relationships HOT 2
- dagmc tet mesh tallies 5.5x higher when run with MPI version of dag-mcnp6.2 HOT 6
- Remove DagMC class from MOAB namespace HOT 1
- Windows Build Failure with Gtest HOT 7
- Can we detect sheet bodies?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dagmc.