Coder Social home page Coder Social logo

Comments (12)

gonuke avatar gonuke commented on August 13, 2024 1

We can introduce a convention of this kind of output and a mechanism for users to influence it. We can pass that through to MOAB for the first two lines.

from dagmc.

pshriwise avatar pshriwise commented on August 13, 2024 1

Staring at this a little bit more after our call this morning. @gonuke would it be sufficient to add a verbose flag to the GeomQueryTool and GeomTopoTool classes in MOAB? We could then include a method in DAGMC to set the verbosity the classes it depends upon (as well as the verbosity of the DagMC class itself).

from dagmc.

gonuke avatar gonuke commented on August 13, 2024 1

I think all the pieces are in place for the next release of MOAB. We will still need to add a line in the DagMC constructor to pass along the verbosity.

from dagmc.

makeclean avatar makeclean commented on August 13, 2024

I thought we had one at some point? maybe I'm mis-remembering?

from dagmc.

pshriwise avatar pshriwise commented on August 13, 2024

Not seeing anything of that nature in the source code 😞 Shame on us...

from dagmc.

gonuke avatar gonuke commented on August 13, 2024

Staring at this a little bit more after our call this morning. @gonuke would it be sufficient to add a verbose flag to the GeomQueryTool and GeomTopoTool classes in MOAB? We could then include a method in DAGMC to set the verbosity the classes it depends upon (as well as the verbosity of the DagMC class itself).

I think that would do it, but is still fairly intrusive. We also would have to act on that flag in DAGMC.

from dagmc.

pshriwise avatar pshriwise commented on August 13, 2024

Agreed, we'd have to act on that flag in DAGMC. And while some changes will be required in MOAB, there's a separate question of how we want to handle verbosity in the DagMC class. Here are the aforementioned lines annotated with which project they come from:

Output Line Class
"Set overlap thickness = 0" MOAB::GeomQueryTool
"Set numerical precision = 0.001" MOAB::GeomQueryTool
"Initializing the GeomQueryTool..." DagMC
"Using faceting tolerance: 0.0001" DagMC
"Building acceleration data structures..." DagMC
"Implicit Complement assumed to be Vacuum" dagmcMetaData

So, as a first step, I think we can decide how we want to handle the output lines coming from DAGMC.

from dagmc.

pshriwise avatar pshriwise commented on August 13, 2024

Cross-linking related MOAB issue here

https://bitbucket.org/fathomteam/moab/issues/166/control-verbosity-in-geomquerytool

from dagmc.

ahnaf-tahmid-chowdhury avatar ahnaf-tahmid-chowdhury commented on August 13, 2024

Are we ready to proceed with the latest MOAB version now that we have fixed the Implicit Complement Position in DAGMC through PR #935?

from dagmc.

gonuke avatar gonuke commented on August 13, 2024

I think it's worth a PR to see how it all works...

from dagmc.

ahnaf-tahmid-chowdhury avatar ahnaf-tahmid-chowdhury commented on August 13, 2024

MOAB is set to the latest version 5.5.1 now through #940

from dagmc.

gonuke avatar gonuke commented on August 13, 2024

This should now be resolved

from dagmc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.