suse / registries-operator Goto Github PK

Each operator can have differents Api groups, we should change the kubic api group name and make it more specific.
https://github.com/kubic-project/registries-operator/tree/master/pkg/apis

i think registry could be ok , open for suggestions

integration-tests: test certificate update

description:

we need to test the certification update in integration tests

Follow-up backport logic from dex-operator tests integration

backport same logic as pr SUSE/dex-operator#3

fix golint and make golint fail to circleci

Description:

Fix current golint issues we have. See log here
Make golint fail in circleci if there an offences ( at moment make check will always succeed)

>>> Reformatting code
pkg/apis/kubic/v1beta1/register.go
/home/dmaiocchi/go/src/github.com/kubic-project/registries-operator/cmd/registries-operator/main.go:1:1: package comment should not have leading space
/home/dmaiocchi/go/src/github.com/kubic-project/registries-operator/cmd/registries-operator/main.go:42:1: comment on exported var Version should be of the form "Version ..."
/home/dmaiocchi/go/src/github.com/kubic-project/registries-operator/cmd/registries-operator/main.go:44:5: exported var Build should have comment or be unexported
/home/dmaiocchi/go/src/github.com/kubic-project/registries-operator/pkg/apis/kubic/v1beta1/registry_types.go:49:1: comment on exported type RegistryCertificateStatus should be of the form "RegistryCertificateStatus ..." (with optional leading article)
/home/dmaiocchi/go/src/github.com/kubic-project/registries-operator/pkg/apis/kubic/v1beta1/registry_types.go:76:1: comment on exported method Registry.GetCertificateSecret should be of the form "GetCertificateSecret ..."
/home/dmaiocchi/go/src/github.com/kubic-project/registries-operator/pkg/apis/kubic/v1beta1/registry_types.go:91:1: receiver name r should be consistent with previous receiver name registry for Registry
/home/dmaiocchi/go/src/github.com/kubic-project/registries-operator/pkg/config/globals.go:21:2: comment on exported var DefaultPrefix should be of the form "DefaultPrefix ..."
/home/dmaiocchi/go/src/github.com/kubic-project/registries-operator/pkg/config/globals.go:24:2: comment on exported var DefaultDeployNumReplicas should be of the form "DefaultDeployNumReplicas ..."
/home/dmaiocchi/go/src/github.com/kubic-project/registries-operator/pkg/test/util.go:1:1: package comment should be of the form "Package test ..."
/home/dmaiocchi/go/src/github.com/kubic-project/registries-operator/pkg/test/util.go:1:1: package comment should not have leading space
/home/dmaiocchi/go/src/github.com/kubic-project/registries-operator/pkg/util/strings.go:26:6: func SafeId should be SafeID

enable tests unit in circle ci when separation is done

#15

Building Docker image from Dockerfile fails

Running a docker build -t <label> . form the project's root directory generates the following error:

make: *** No rule to make target 'deps'. Stop.
make: Leaving directory '/go/src/github.com/kubic-project/registries-operator'
The command '/bin/sh -c make -C $BUILD_DIR clean deps' returned a non-zero code: 2

The offending command in the Dockerfile is RUN make -C $BUILD_DIR clean deps

suse / registries-operator Goto Github PK

registries-operator's Issues

Problem

Infos

Description:

Description:

description:

Description:

Recommend Projects

Recommend Topics

Recommend Org