superfaz / mstest-analyzer

A .Net analyzer that helps to avoid basic mistakes with the MSTest framework

mstest-analyzer

A .Net analyzer that helps to avoid basic mistakes with the MSTest framework

Installation

nuget install mstest-analyzer

Implemented checks

Code	Description
MT1001	Public class should have a test attribute
MT1002	Internal class should not have a test attribute
MT1003	Public method should have a test attribute
MT1004	Non-Public method should not have a test attribute

mstest-analyzer's Issues

Public methods in private class raise the MT1003 warning

How to reproduce:
Create a nested private class in a test class
Add a public method
Run the build with analyzer

Expected result:
No warning

MT1003 auto-fix doesn't work as expected

How to reproduce

Create a test class with documentation like:

using Microsoft.VisualStudio.TestTools.UnitTesting;

namespace MyTest
{
    /// <summary>
    /// Tests the <see cref="MyClass"/> class.
    /// </summary>
    [TestClass]
    public class MyClassTest
    {
        /// <summary>
        /// Tests the <see cref="MyClass.MyClass"/> constructor.
        /// </summary>
        public void Constructor()
        {
        }
    }
}

Use the auto-fix feature for MT1003, result is:

using Microsoft.VisualStudio.TestTools.UnitTesting;
using Microsoft.VisualStudio.TestTools.UnitTesting;

namespace MyTest
{
    /// <summary>
    /// Tests the <see cref="MyClass"/> class.
    /// </summary>
    [TestClass]
    public class MyClassTest
    {
        [TestMethod]
          /// <summary>
                              /// Tests the <see cref="MyClass.MyClass"/> constructor.
                              /// </summary>
        public void Constructor()
        {
        }
    }
}

Expected result

• The using reference should not be doubled
• The [TestMethod] should be between the comment and the method signature
• The method comment should remain untouched

The result of the auto-fix should be:

using Microsoft.VisualStudio.TestTools.UnitTesting;

namespace MyTest
{
    /// <summary>
    /// Tests the <see cref="MyClass"/> class.
    /// </summary>
    [TestClass]
    public class MyClassTest
    {
        /// <summary>
        /// Tests the <see cref="MyClass.MyClass"/> constructor.
        /// </summary>
        [TestMethod]
        public void Constructor()
        {
        }
    }
}

Extra dependencies

The published nuget package has dependencies on FxCopAnalyzers and StyleCop.Analyzers.

Without having read your code I imagine that those should be private assets.