louder's People
louder's Issues
Thanks!
Hi @suns3t, nice work with the homework ๐
The goals of this homework are:
- to know how to implement authentication from scratch in Rails with the help of the
has_secure_password
class method and thebcrypt
gem (while understanding what they do under the hood) - to design a more complex schema for a web app and be more familiar with ActiveRecord API such as custom foreign keys for
belongs_to
/has_many
, usinghas_many :through
and building more advanced queries by chainingwhere
,order
, andmerge
- to build more complex forms in views that involve multiple models.
Quick review:
- Nice work with routes configuration.
- Good logic with not allow add friend/sent messages to yourself.
- Nice when checking any friends before allow to send messages.
- Good work with models' relationship definition.
- Good use of
scope
. - Good use with
helper_method
,before_action
.
Issues:
- Can't login.
Suggestions
- You should validate password presence, in case of Facebook login, you can generate a password for it. Ideally, send that password to the user's email.
- Remember to publish your Facebook App. Right now I can't login with Facebook.
- Should validate
email
validity on your sign up form. - We can define multiple helper methods in the same line, g.e.
helper_method :current_user, :get_path
.
Congrats again on the submission. Keep your good work ๐ฏ Let us know if you have any feedback.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.