sumeshpremraj / rundeck-scripts Goto Github PK

Add logging to summary-report.py. Some suggestions:

• Log the start and end of script
• Log the number of jobs that failed. If no jobs failed, then log that.

summary-report.py currently has variables like BASE_URL and PROJECT in the script, that the user needs to edit for each server.

Make the script take arguments from the command line. Something like:

$ python summary-report.py -P 'Production' -f '[email protected]' -t '[email protected]' -s 'smtp.domain.com' -B 'https://rundeck.internal.domain.tld'

See CONTRIBUTING.md on how to send a PR.

summary-report.py currently has SMTP port hard coded.

There is already #3 to allow the user to specify the port via command line argument, this is an improvement over that issue.

Autodetect SMTP port by trying all the common ports one by one - 587, 465, 25. This should be done only if the user does not specify a port.

You might want to wait for #1 and #3 to be fixed and merged so that it becomes a bit easier to work on this.

The SMTP port in summary-report.py is currently hardcoded to 587.

Allow user to specify the port to connect to, via command line argument. If no port is specified, default to port 587.

You might want to wait for #1 to be fixed and merged so that it becomes a bit easier to fix this issue.

See README.md for details about the script, and CONTRIBUTING.md on how to send a PR.

summary-report.py currently has two separate variables for sender email:

• smtp_username: the address to authenticate to the SMTP server (along with its password contained in smtp_password)
• sender: address in the data-from, which appears in the email client

Make the required changes to use the smtp_username as sender by default.

You might want to wait for #1 to be fixed and merged so that it becomes a bit easier to fix this issue.

See README.md for details about the script, and CONTRIBUTING.md on how to send a PR.