suitcss / stylelint-config-suitcss Goto Github PK

@simonsmith I'm going to prepare a 7.0 compatible release for you :)

I know it feels like stylelint releases are coming thick and fast, but it's been 4 months since the last major release.

This new release is significant in that a lot of work has gone into making the linter more sustainable i.e. putting in place systems to empower the community to build plugins and processors, rather than have these volatile features in the core. Hopefully this will slow down the pace of stylelint releases (especially major ones) even further. I think most of the contributors are looking forward to a little breather as well now that 7.0.0 is out of the door :)

A new version of the plugin has been released.

https://github.com/suitcss/stylelint-config-suitcss/blob/master/index.js#L62 just needs to be changed to order/properties-alphabetical-order.

Because of this deprecated rule: https://github.com/suitcss/stylelint-config-suitcss/blob/master/index.js#L58

See error here: https://travis-ci.org/ismay/ismay.github.io/builds/116449021#L1663

This common pattern in many SUIT utils shows as an error:

@media (--sm-viewport) {
x <-- this line is an error
  .u-sm-afterNone {
    margin-left: 0 !important;
  }

}

I can fix it by setting:

    "rule-nested-empty-line-before": "always-multi-line"

@jeddy3 Before I change it just wanted to know if there is something I've missed as to why it had except: ["first-nested"]? Cheers

@simonsmith We're freeing up the stylelint org to focus on stylelint as a tool rather than the configs. As such we intend to move the SuitCSS, Wordpress, and CSS Recipes configs out of the org. I thought the SuitCSS org would make a good home for this repo as you'll be using it to enforce the SuitCSS code style on the components. What do you think?

Currently https://www.npmjs.com/package/stylelint-config-suitcss links back to the old repo URL's

• Update old stylelint/stylelint-config-suitcss URL's to suitcss/stylelint-config-suitcss in package.json

A lot of rules that were deprecated, see: https://github.com/stylelint/stylelint/releases/tag/7.8.0

At the moment, some of those are being used which is causing warnings in the linter. We should upgrade!

//cc @jeddy3

stylelint deprecated some rules recently, such as function-url-quotes. Could you kindly remove those in favor of the proposed solutions from stylelint output?

stylelint-config-suitcss uses stylelint v8 in peer dependencies but the versions used for stylelint-suitcss and stylelint-order still use stylelint v7 which lead to multiple stylelint libraries (both v7 and v8) present in node_modules.

This causes problems in a project I'm working on with a big dependency chain.

Update the versions as follows

• stylelint-suitcss : v2.0.0 (released after this PR)
• stylelint-order : v0.8.0 v0.7.0 (v0.8 drops support for Node 4/5. Sticking to 0.7 to not have a breaking change).

Thanks

the only things in my app.css file are imports

@import "suitcss-base";
@import "suitcss-utils";
@import "theme.css";
@import "theme-map.css";

any suggestions on how to silence or fix these would be appreciated.
will update if I discover where I have gone wrong here.

thanks!

Can the package.json be enhanced to list the compatible versions of stylelint as a peerDependency?

• Update the AppVeyor URL in README.MD from stylelint/stylelint-config-suitcss to suitcss/stylelint-config-suitcss
• Update the AppVeyor repo configuration from stylelint/stylelint-config-suitcss to suitcss/stylelint-config-suitcss via https://ci.appveyor.com/project/stylelint/stylelint-config-suitcss/settings