subsurfacestudios / sharedutils

Shared utilities for Unity projects by Subsurface Studios.

SubsurfaceStudios

sharedutils's Issues

Memory: .NET does not support generic types with explicit layout.

This seems like a glaring flaw in the runtime, and prevents TaggedUnion<A, B, ...> and Union<A, B, ...>. Unfortunately, this restriction occurs as a runtime error, so I was not aware of it until now.

While it's technically possible to get around this using our Bytes API and a fixed-size byte array, this incurs both a marshaling cost as well as the necessity of a heap allocation, which ruins the point of a Union.

For that reason, it's probably worthwhile to remove the Union struct for now, at least until a reasonable implementation can be found. If you have a way to inline a byte array of potentially varying size into a struct, please let me know.

In the meantime, Union and TaggedUnion will remain broken, until they are removed or fixed.

PagedList: Replace nullable types with an Option utility.

Currently, we use T where T: class in PagedList as well as the null value as an empty slot in the list. This is a bit of a hack, and it would be better to use an Option type or similar to represent the null value. This would also allow us to use value types in PagedList.

FIXME for reference:

SharedUtils/PagedList.cs

Lines 6 to 7 in 96e4e95

	// FIXME: This should be converted to use TaggedUnion<A, B> instead of
	// using nulls to represent empty items.