studio-nine / nine.geometry Goto Github PK

Should we add something alike MathHelper?

Fix the appveyor build

System.Numerics.Vectors is the core type of Vectors and Matrix in corefx. Using types under that package allows us to be SIMD ready and interoperable with other libraries. We should drop the types under MonoGame

We have to create a nuget package.

Take this as an example:

        public void Contains(ref BoundingBox boundingBox, out ContainmentType result) => result = this.Contains(boundingBox);

        public ContainmentType Contains(BoundingBox boundingBox)
        {
            ContainmentType result;
            Intersection.Intersect(ref boundingBox, ref this, out result);
            return result;
        }

BoundingBox.Contains(ref BoundingBox) calls Contains(BoundingBox), which causes the box to be copied.

In addition, not all contains method has a ref counter part. E.g., we have a Contains(BoundingFrustum) but there is no Contains(ref BoundingFrustum)

The suggestion is to move all these containment test methods into Intersection, each method has a Contains(struct) and Contains(ref struct) pair. BoundingBox only contain basic methods that does not take a ref structures, like Contains(Vector3) and Intersects(BoundingBox).

An example of dynamic BVH can be found in Farseer Physics DynamicTree.cs

What frameworks would be best to support?

Apparently dnx451 == dotnet5.4 which changed a while ago, so that should be fixed.
And dnxcore50 falls under dotnet from what I understand.

Should there be two different types of ISpatialQueryable one for 2D and one for 3D?

So QuadTree would only work with 2D and Octree would only work with 3D.