strophe / strophejs-bower Goto Github PK

I'm sorry please consider this issue as no issue. I looked to sources of master branch of strophe (https://github.com/strophe/strophejs) instead of 1.1.0.
I hope that version with options.sync supported will be released soon for bower.

missing options.sync (was present in ver. 1.1.0)

bosh.js

_processRequest: function (i)
{
...
// ver 1.1.0:
req.xhr.open("POST", this._conn.service, this._conn.options.sync ? false : true);
// ver 1.1.1:
req.xhr.open("POST", this._conn.service, true);
...

since options.sync is now missing it is no longer possible to address the issue with XHR called from window.onunload (we have to call synchronous XHR).

We don't anymore need a separate repo for bower support. I therefore suggest we delete it.

Yays or nays?

CC @astro @metajack @dlo @thepug @Gordin

Could you please mark the latest commit in master with the v1.1.3 tag? It will make installation via bower a bit easier (you will not be required to specify SHA hash, "Strophe.js": "strophe/strophejs-bower#1.1.3" will be enough).

Also a few more suggestions:

• How about changing name in bower.json to be strophe or strophejs? This will make things more consistent. strophe was used in the original repository for example.
• Do you know who did register the strophe shortcut in bower registry? I think shortcut should be pointed now to this repo instead. But this requires unregistering at first, see: http://bower.io/#registering-packages.