strangelights / slack_dark_theme Goto Github PK

Bottom section of Files tab background displayed as white after entering search result.

Blinded by the white...

When trying the run the script on the latest v4.0.1 release, the dark theme is failing to apply and a console error is thrown:

/Applications/Slack.app/Contents/Resources/app.asar/dist/ssb-interop.bundle.js:8 Uncaught ReferenceError: $ is not defined
    at HTMLDocument.<anonymous> (/Applications/Slack.app/Contents/Resources/app.asar/dist/ssb-interop.bundle.js:8)

That error is caused by the $.ajax() Jquery function that this theme relies on in slack_dark_theme.js.

Looks like Slack may be moving away from Jquery use. To get around this, it's time to replace that file's Jquery ajax method with the vanilla JS equivalent.

To update any part of the theme, it's currently necessary to run the full app.asar unpack/repackage process. This has the potential to inject the event listener JS into the ssb-interop.bundle.js multiple times.

Although it doesn't seem to have any current side effects, this seems inefficient and could be a source of future bugs as updates progress.

To get around this, and to make it easier for users to add their own custom styling without having to fork and maintain their own repo, it would be beneficial to add an optional update flag for the bash script, which would only apply updated CSS and bypass the rest of the process.