stphch / prj-rev-bwfs-dasmoto Goto Github PK

You should consider adding an alt attribute to the images, that way if any of the images don't load for some reason, you don't get the broken link icon, rather the text you specify in alt will be displayed, more info here: https://www.w3schools.com/tags/att_img_alt.asp

Great job keeping both the css and HTML neat and organized using comments and indentation. run through your HTML and make sure your indentation is consistent. everything that is nested to the same level should be indented the same.
consider making use of some well-placed line breaks throughout the HTML to help define each content chunk and make things easier to identify at a glance.
more info about HTML styling, in general, can be found here - https://www.w3schools.com/html/html5_syntax.asp

You want to be really careful when you are using & in code, reason being is that sometimes it can be interpreted as an AND in code and can cause some unexpected things to happen. To keep it safe, you're going to want to use '&' Check this page for more information: https://www.w3schools.com/html/html_entities.asp

Project name: Dasmoto's Arts & Crafts
Grade: Meets Expectations

Summary: Good job completing this project and submitting it on time! You have learned to work locally in your text editor and that is a big step. Your file structure was well organized and your heading hierarchy was coherent.

Your project was tidy and well-formatted throughout. For a more in depth look at best practices, I recommend reading through this chapter: http://learn.shayhowe.com/html-css/writing-your-best-code/

For future projects, you may want to download all images and use relative paths to link to them rather than absolute paths. While this isn’t strictly necessary, I do encourage it as new developers often struggle with directory structure at first and this is an important concept to get right. For more info, please read this section:
https://internetingishard.com/html-and-css/links-and-images/#absolute-relative-and-root-relative-links

Finally, I encourage you to start thinking about web accessibility. This is something you will learn more about in week 7 but for a quick overview: ​https://www.codecademy.com/articles/accessibility

Overall, you did an excellent job here. Keep up the hard work!