stormpass / node-red-contrib-amqp Goto Github PK

Hello,

I have a problem with how the connection error is (not) implemented:
https://github.com/Stormpass/node-red-contrib-amqp/blob/main/src/Amqp.ts#L74
When there is a connection error, Node-RED disconnect from RabbitMQ and does not attempt to reconnect.
I have to redeploy the node to recreate a connection.

Would it be possible to force a reconnection when there is a connecion error ?
Or maybe there is another way (that I don't know about) to handle it in Node-RED ?

Thank you.

After creating a flow with manual message acknowledgment, Node-RED automatically restarts with the following message. I also copied the example, and the same error occurs. The Node-RED version is 3.1.8.

[error] IllegalOperationError: Channel closed
at Channel. (/usr/src/node-red/node_modules/amqplib/lib/channel.js:159:11)
at C.closeBecause (/usr/src/node-red/node_modules/amqplib/lib/channel.js:211:8)
at /usr/src/node-red/node_modules/amqplib/lib/channel_model.js:72:19
at node:internal/util:441:7
at new Promise ()
at node:internal/util:427:12
at Channel.close (/usr/src/node-red/node_modules/amqplib/lib/channel_model.js:74:7)
at reconnect (/usr/src/node-red/node_modules/@stormpass/node-red-contrib-amqp/build/src/nodes/amqp-out.js:74:29)
at Channel. (/usr/src/node-red/node_modules/@stormpass/node-red-contrib-amqp/build/src/nodes/amqp-out.js:110:31)

I am trying to consume messages from an existing queue. The queue has its x-message-ttl set. When I add the amqp-in node to consume that queue, I get this log:

"Could not consume message: Error: Operation failed: QueueDeclare; 406 (PRECONDITION-FAILED) with message "PRECONDITION_FAILED - inequivalent arg 'x-message-ttl' for queue 'queueName' in vhost 'vhost': received none but current is the value '9000' of type 'long'""

How should I fix this?

Hi, with the current implementation RPC calls are only possible on the default exchange, because the exchange name is always overwritten with "":
https://github.com/Stormpass/node-red-contrib-amqp/blob/3ee9e0ef7dadd30d8eefb8f36050e4a7fc5eb329/src/Amqp.ts#L201C33-L201C33

Maybe to also be able to do rpc calls on other exchanges this line should be changed?

Installation from node-red palette fail with:
2023-10-30T20:13:46.236Z [err] 500 Internal Server Error - GET https://registry.npmjs.org/@stormpass%2fnode-red-contrib-amqp - KV GET failed: 401 Unauthorized

That URL is not working. I believe the correct URL should be:
https://registry.npmjs.org/package/node-red-contrib-amqp

A quick glace compared to others give me the guess that you should not have your username as part of the name on package.json

ampq-in tries to create the queue before connecting to it. If the user does not have the right to create the queue the call fails with a 403. The expected behaviour should be to try to connect to the queue before trying to create it.