stolexiy / styleguide Goto Github PK

FORMS, VERTICAL TABS empty in both themes(maybe in D8 should be different element)

LINKS block has only list without links.

As module mostly working now it's time to clean-up and refactor

Render elements should be collected from element_info service (default plugin)
Elements that depends on their modules should have a kind of \Drupal\Core\Field\FormatterInterface::isApplicable() method to prevent plugin manager to instantiate them when no required modules enabled

In D8 Seven maintenance styles applied only on maintenance and install pages. An when we apply them on styleguide page of seven we have layout broken.
Possble solutions:

1. Change core Seven maintenance page styles to make more direct selectors.
2. Add some module styles to override broken styles.
3. Remove maintenance from Styleguide module
4. Set different blocks or pages in styleguide module by categories

Block is empty. Is this exists in D8?

Don't concatenate rendered content in StyleguideController ($items[]['content']). Use nested render arrays instead. In Drupal 8 render arrays can be nested.

Add comments display. It exists in D7 version.

In D7 they exist. Nothing in ported

In ported version readmore link is empty and has wrong class. .node-readmore

Same for help more link

MENU TREE doesn't looks like menu tree in bartik theme. But ok in seven. Different layout maybe, or missed styles in D8 bartik

Set current site image styles in styleguide display, instead just horizontal and vertical. It exists in D7 version

Both blocks not ported

Create a custom plugin type for this.

Ported collapsible fieldsets not work.