ArgumentError after upgrade stimulus_reflex and cable_ready about stimulus_reflex

[marcoroth]

Hey @sFrenkie, thanks for reporting this!

I think this is related to the stimulus_reflex_testing gem.

https://github.com/podia/stimulus_reflex_testing/blob/main/lib/stimulus_reflex/test_reflex_patches.rb#L16

We changed the way cable_ready is accessed within the Reflex class in d493e1b

I'll try to put up a pull request for the testing gem to get this resolved!

[sFrenkie]

It seems that is not related to stimulus_reflex_testing

but in stimulus_reflex-3.5.0.rc2/lib/stimulus_reflex/cable_readiness.rb
the block prepended expect the arguments (usualy method prepended is from core Ruby e.g. for Ruby 3.0 https://ruby-doc.org/core-3.0.0/Module.html#method-i-prepended)

It expects use prepended from active concern so it seems that some requires does not worked for me

[sFrenkie]

Confirmed it's cause old rails 6.0.6 where arguments is expected https://api.rubyonrails.org/v6.0.6.1/classes/ActiveSupport/Testing/SetupAndTeardown.html#method-c-prepended
from rails 6.1 is optional

[marcoroth]

@sFrenkie Would it help if make the argument optional?

diff --git a/lib/stimulus_reflex/cable_readiness.rb b/lib/stimulus_reflex/cable_readiness.rb
index 9bb2345..14b85a9 100644
--- a/lib/stimulus_reflex/cable_readiness.rb
+++ b/lib/stimulus_reflex/cable_readiness.rb
@@ -6,7 +6,7 @@ module StimulusReflex
   module CableReadiness
     extend ActiveSupport::Concern

-    prepended do
+    prepended(mod = nil) do
       attr_reader :cable_ready
     end

[marcoroth]

I guess the other option would be to stop supporting Rails 6.0 with StimulusReflex 3.5

[sFrenkie]

Sorry for delay. Yeat it's better to stop supporting rails 6 ;)
I've ugpraded and it works well.

[marcoroth]

Awesome, thank you for the feedback @sFrenkie!