`stimulus-reflex:ready` event should only be emitted once per page load about stimulus_reflex

[marcoroth]

I don't think this should be a big deal, since we just exported that function a few commits ago in #602.

So it's never actually called twice unless you are explicitly importing the setupDeclarativeReflexes() function and calling it yourself in your application.

One solution might be to just move the emitEvent('stimulus-reflex:ready') to the eventlistener in javascript/stimulus_reflex.js:

document.addEventListener('readystatechange', () => {
  if (document.readyState === 'complete') {
    setupDeclarativeReflexes()
    emitEvent('stimulus-reflex:ready')
  }
})

[leastbad]

So it's never actually called twice unless you are explicitly importing the setupDeclarativeReflexes() function and calling it yourself in your application.

I don't believe that's correct. We call it every time the mutation observer picks up new elements.

stimulus_reflex/javascript/stimulus_reflex.js

Line 64 in 500e6c9

const observer = new MutationObserver(setupDeclarativeReflexes)

[marcoroth]

Oh, right. But that would mean that we were also emitting the event multiple times for a long time.

[leastbad]

Yes, stimulus-reflex:ready is a relatively recent addition. It's possible "very few" are using it, yet.