stevepacker / docker-containers Goto Github PK

The direct download of the s6-overlay is not verified.

Either the download should be verified against the public key:
https://github.com/just-containers/s6-overlay#verifying-downloads

Or their provided base image could be used:
https://github.com/just-containers/s6-overlay#our-s6-overlay-based-images

Or the stuff can be installed directly through the alpine package manager, like they do in their alpine base image:
https://github.com/harningt/docker-base-alpine-s6-overlay/blob/edge/Dockerfile

best,
Christian

The Samba Dockerfile calls alpine:latest which means that it's unclear which version of alpine is in use, and also which packages.

We currently have different versions of samba in different versions of alpine. v3.3 provides Samba 4.2, v3.4 provides Samba 4.4, and v3.5 provides Samba 4.5.

alpine:latest on the other hand provides whatever Samba was available at the time of building "One year ago". It's unclear which Samba that is without running image and interrogating the container.

Unfortunately, dockerhub only rebuilds when someone commits to the github repository.

It would be much more useful to tag the container with the version in use, either the Samba version or the Alpine Version. There are considerable differences between Samba 4.2 and 4.3 in particular that drew my attention to this, particularly when dealing with Windows 10 clients which require the SMB3_11 protocol.

Cheers!
Tudor.

On startup:

/etc/Caddyfile:42 - Parse error: Duplicate status code entry: 508

Please, delete duplicate line in https://github.com/stevepacker/docker-containers/blob/caddy-php7/Caddyfile

Hi,

I am attempting to use the samba docker container to load an already-existing data set with an already-existing config file.

So, I just attempted to mount /etc/samba as a volume. -v /dockerdata/etc/samba:/etc/samba and the data set also in the place the config file specifies.

However, it appears that the samba.s6 file overwrites whatever is at CONFIG_FILE, /etc/samba/smb.conf

Would it be possible to detect the existence of CONFIG_FILE before the cat > ${CONFIG_FILE} << __EOF__ command?

Cheers and thanks for building it!

Samba has 2 services smbd and nmbd.

Currently, only smbd is called by s6.

I've tested a version that copies samba.s6 to nmbd.s6 and just replaces the smbd call with nmbd and it works. :-)

Then as expected add it to /etc/services.d/nmbd/run and voila!

Would you like a patch?