Coder Social home page Coder Social logo

go-uncalled's People

Contributors

stevenh avatar

Stargazers

avatar avatar avatar

Watchers

avatar avatar avatar

go-uncalled's Issues

Data race when using flag -config

I tried uncalled and when I'm specifying a config there's a data race. Installed version of uncalled is v0.8.1-0.20221111161324-13e1a747a81f.

$ lsb_release -a
No LSB modules are available.
Distributor ID:	Debian
Description:	Debian GNU/Linux 9.13 (stretch)
Release:	9.13
Codename:	stretch
$ go version
go version go1.19.4 linux/amd64
$ go install -a -race github.com/stevenh/go-uncalled/cmd/uncalled@main
$ uncalled -config "$GOPATH/pkg/mod/github.com/stevenh/[email protected]/pkg/uncalled/.uncalled.yaml" ./...
==================
WARNING: DATA RACE
Write at 0x00c0001b8020 by goroutine 8240:
  github.com/stevenh/go-uncalled/pkg/uncalled.(*Rule).validate()
      /home/hansg/go/pkg/mod/github.com/stevenh/[email protected]/pkg/uncalled/config.go:247 +0x395
  github.com/stevenh/go-uncalled/pkg/uncalled.(*Config).validate()
      /home/hansg/go/pkg/mod/github.com/stevenh/[email protected]/pkg/uncalled/config.go:152 +0x206
  github.com/stevenh/go-uncalled/pkg/uncalled.Config.copy()
      /home/hansg/go/pkg/mod/github.com/stevenh/[email protected]/pkg/uncalled/config.go:114 +0x94
  github.com/stevenh/go-uncalled/pkg/uncalled.(*loader).run()
      /home/hansg/go/pkg/mod/github.com/stevenh/[email protected]/pkg/uncalled/loader.go:26 +0x13c
  github.com/stevenh/go-uncalled/pkg/uncalled.(*loader).run-fm()
      <autogenerated>:1 +0x44
  golang.org/x/tools/go/analysis/internal/checker.(*action).execOnce()
      /home/hansg/go/pkg/mod/golang.org/x/[email protected]/go/analysis/internal/checker/checker.go:791 +0x1544
  golang.org/x/tools/go/analysis/internal/checker.(*action).execOnce-fm()
      <autogenerated>:1 +0x39
  sync.(*Once).doSlow()
      /usr/local/go/src/sync/once.go:74 +0x101
  sync.(*Once).Do()
      /usr/local/go/src/sync/once.go:65 +0x46
  golang.org/x/tools/go/analysis/internal/checker.(*action).exec()
      /home/hansg/go/pkg/mod/golang.org/x/[email protected]/go/analysis/internal/checker/checker.go:643 +0x4c
  golang.org/x/tools/go/analysis/internal/checker.execAll.func1()
      /home/hansg/go/pkg/mod/golang.org/x/[email protected]/go/analysis/internal/checker/checker.go:631 +0x35
  golang.org/x/tools/go/analysis/internal/checker.execAll.func2()
      /home/hansg/go/pkg/mod/golang.org/x/[email protected]/go/analysis/internal/checker/checker.go:637 +0x47

Previous write at 0x00c0001b8020 by goroutine 8238:
  github.com/stevenh/go-uncalled/pkg/uncalled.(*Rule).validate()
      /home/hansg/go/pkg/mod/github.com/stevenh/[email protected]/pkg/uncalled/config.go:247 +0x395
  github.com/stevenh/go-uncalled/pkg/uncalled.(*Config).validate()
      /home/hansg/go/pkg/mod/github.com/stevenh/[email protected]/pkg/uncalled/config.go:152 +0x206
  github.com/stevenh/go-uncalled/pkg/uncalled.Config.copy()
      /home/hansg/go/pkg/mod/github.com/stevenh/[email protected]/pkg/uncalled/config.go:114 +0x94
  github.com/stevenh/go-uncalled/pkg/uncalled.(*loader).run()
      /home/hansg/go/pkg/mod/github.com/stevenh/[email protected]/pkg/uncalled/loader.go:26 +0x13c
  github.com/stevenh/go-uncalled/pkg/uncalled.(*loader).run-fm()
      <autogenerated>:1 +0x44
  golang.org/x/tools/go/analysis/internal/checker.(*action).execOnce()
      /home/hansg/go/pkg/mod/golang.org/x/[email protected]/go/analysis/internal/checker/checker.go:791 +0x1544
  golang.org/x/tools/go/analysis/internal/checker.(*action).execOnce-fm()
      <autogenerated>:1 +0x39
  sync.(*Once).doSlow()
      /usr/local/go/src/sync/once.go:74 +0x101
  sync.(*Once).Do()
      /usr/local/go/src/sync/once.go:65 +0x46
  golang.org/x/tools/go/analysis/internal/checker.(*action).exec()
      /home/hansg/go/pkg/mod/golang.org/x/[email protected]/go/analysis/internal/checker/checker.go:643 +0x4c
  golang.org/x/tools/go/analysis/internal/checker.execAll.func1()
      /home/hansg/go/pkg/mod/golang.org/x/[email protected]/go/analysis/internal/checker/checker.go:631 +0x35
  golang.org/x/tools/go/analysis/internal/checker.execAll.func2()
      /home/hansg/go/pkg/mod/golang.org/x/[email protected]/go/analysis/internal/checker/checker.go:637 +0x47

Goroutine 8240 (running) created at:
  golang.org/x/tools/go/analysis/internal/checker.execAll()
      /home/hansg/go/pkg/mod/golang.org/x/[email protected]/go/analysis/internal/checker/checker.go:637 +0x22e
  golang.org/x/tools/go/analysis/internal/checker.analyze()
      /home/hansg/go/pkg/mod/golang.org/x/[email protected]/go/analysis/internal/checker/checker.go:307 +0x1e5
  golang.org/x/tools/go/analysis/internal/checker.Run()
      /home/hansg/go/pkg/mod/golang.org/x/[email protected]/go/analysis/internal/checker/checker.go:147 +0xa79
  golang.org/x/tools/go/analysis/singlechecker.Main()
      /home/hansg/go/pkg/mod/golang.org/x/[email protected]/go/analysis/singlechecker/singlechecker.go:75 +0x34d
  main.main()
      /home/hansg/go/pkg/mod/github.com/stevenh/[email protected]/cmd/uncalled/main.go:12 +0x2e

Goroutine 8238 (running) created at:
  golang.org/x/tools/go/analysis/internal/checker.execAll()
      /home/hansg/go/pkg/mod/golang.org/x/[email protected]/go/analysis/internal/checker/checker.go:637 +0x22e
  golang.org/x/tools/go/analysis/internal/checker.analyze()
      /home/hansg/go/pkg/mod/golang.org/x/[email protected]/go/analysis/internal/checker/checker.go:307 +0x1e5
  golang.org/x/tools/go/analysis/internal/checker.Run()
      /home/hansg/go/pkg/mod/golang.org/x/[email protected]/go/analysis/internal/checker/checker.go:147 +0xa79
  golang.org/x/tools/go/analysis/singlechecker.Main()
      /home/hansg/go/pkg/mod/golang.org/x/[email protected]/go/analysis/singlechecker/singlechecker.go:75 +0x34d
  main.main()
      /home/hansg/go/pkg/mod/github.com/stevenh/[email protected]/cmd/uncalled/main.go:12 +0x2e
==================

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.