stevegrunwell / advanced-post-excerpt

Replace the default Post Excerpt meta box with a superior editing experience.

👋 Hello, there!

I'm Steve, and I love building tools to help people build better software.

By day, I'm a Staff Software Engineer at Mailchimp, improving the way we handle audience information and our general involvement in the PHP ecosystem.

PHP is my bread-and-butter, and I love building out SaaS and other products using Laravel. I'm also a WordPress plugin author and core contributor, but my real passion is building code quality tools; it shouldn't come as any surprise that I've spent a lot of time working with CI/CD pipelines and all of the tooling that gets run as part of them.

I'm also a regular conference speaker (or at least was, pre-pandemic), so you may have met me at any number of PHP, WordPress, or other software-related events.

You can learn more about me over at stevegrunwell.com, follow me on Mastodon, or connect with me on LinkedIn.

advanced-post-excerpt's Issues

Add PHP_CodeSniffer to the Travis CI build

The early Travis CI builds for the repo were breaking due to missing coding standards.

$ ./vendor/bin/phpcs
PHP Fatal error:  Uncaught exception 'PHP_CodeSniffer_Exception' with message 'Referenced sniff "WordPress-Extra" does not exist' in /home/travis/build/stevegrunwell/advanced-post-excerpt/vendor/squizlabs/php_codesniffer/CodeSniffer.php:1121
Stack trace:
#0 /home/travis/build/stevegrunwell/advanced-post-excerpt/vendor/squizlabs/php_codesniffer/CodeSniffer.php(734): PHP_CodeSniffer->_expandRulesetReference(Object(SimpleXMLElement), '/home/travis/bu...', 0)
#1 /home/travis/build/stevegrunwell/advanced-post-excerpt/vendor/squizlabs/php_codesniffer/CodeSniffer.php(551): PHP_CodeSniffer->processRuleset('/home/travis/bu...')
#2 /home/travis/build/stevegrunwell/advanced-post-excerpt/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php(844): PHP_CodeSniffer->initStandard(Array, Array)
#3 /home/travis/build/stevegrunwell/advanced-post-excerpt/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php(104): PHP_CodeSniffer_CLI->process()
#4 /home/travis/build/stevegrunwell/advanced-post-excerpt/vendor/squizlabs/php_codesniffer/scripts/phpcs(2 in /home/travis/build/stevegrunwell/advanced-post-excerpt/vendor/squizlabs/php_codesniffer/CodeSniffer.php on line 1121
Fatal error: Uncaught exception 'PHP_CodeSniffer_Exception' with message 'Referenced sniff "WordPress-Extra" does not exist' in /home/travis/build/stevegrunwell/advanced-post-excerpt/vendor/squizlabs/php_codesniffer/CodeSniffer.php on line 1121
PHP_CodeSniffer_Exception: Referenced sniff "WordPress-Extra" does not exist in /home/travis/build/stevegrunwell/advanced-post-excerpt/vendor/squizlabs/php_codesniffer/CodeSniffer.php on line 1121
Call Stack:
    0.0002     235440   1. {main}() /home/travis/build/stevegrunwell/advanced-post-excerpt/vendor/squizlabs/php_codesniffer/scripts/phpcs:0
    0.0141    2303416   2. PHP_CodeSniffer_CLI->runphpcs() /home/travis/build/stevegrunwell/advanced-post-excerpt/vendor/squizlabs/php_codesniffer/scripts/phpcs:25
    0.0146    2370448   3. PHP_CodeSniffer_CLI->process() /home/travis/build/stevegrunwell/advanced-post-excerpt/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php:104
    0.0149    2382864   4. PHP_CodeSniffer->initStandard() /home/travis/build/stevegrunwell/advanced-post-excerpt/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php:844
    0.0150    2384416   5. PHP_CodeSniffer->processRuleset() /home/travis/build/stevegrunwell/advanced-post-excerpt/vendor/squizlabs/php_codesniffer/CodeSniffer.php:551
    0.0153    2388616   6. PHP_CodeSniffer->_expandRulesetReference() /home/travis/build/stevegrunwell/advanced-post-excerpt/vendor/squizlabs/php_codesniffer/CodeSniffer.php:734
The command "./vendor/bin/phpcs" exited with 255.

I removed the check in 5b0e24b, but eventually it should be restored once I have more time to figure out why it wasn't working.

Remove alignment from default buttons

Advanced Post Excerpt uses pretty stock wp_editor() settings, which includes things like alignment (left/center/right/justified) which aren't really appropriate for post excerpts in most cases.

Using the ape_editor_settings filter, these defaults should be removed. Instructions should be added to the README for unhooking this new callback, in case anyone was using them.

Plugin doesn't use`load_plugin_textdomain()`

According to GlotPress, Advanced Post Excerpt isn't properly configured for localization.

Details from Slack:

Import of advanced-post-excerpt
Time: Sat, 04 Mar 2017 15:41:40 +0000, Development Log
Code for dev (advanced-post-excerpt/trunk/) in process...
This plugin doesn't use load_plugin_textdomain().
Code for dev was processed.
Readme for dev (advanced-post-excerpt/trunk/) in process...
The GlotPress projects were updated.
Result of the POT import: 13 new strings added, 0 updated, 0 fuzzied, and 0 obsoleted.
Readme for dev was processed.

WordPress 5.x Compatibility

With the launch of WordPress 5.0 imminent, it's probably time to make sure this plugin will continue to function when Gutenberg is present.

Drop PHP 5.x support

Since PHP 5.x has reached EOL, it's time to do away with any support for older versions. "Requires PHP" should be set to "7.0" (ideally 7.1, but baby steps) and compatibility checks + docs updated accordingly.

Move to namespaced functions

Since #6 is dropping any pretense of PHP 5.x support, we can safely move to namespaces for a cleaner, more readable codebase.

Add the code snippet from the v0.2.0 release to README.md

Version 0.2.0 removed the alignment buttons from Advanced Post Excerpt, and the release notes include a snippet to restore the previous behavior.

This code snippet should be added to the main README.md file under the "Configuration" heading.