stevebrun / swiftofx Goto Github PK

Some ofx files do not include FI information (e.g. Barclays Bank). Following code in Finance.swift makes FI parsing optional
/// Information about the entity which provided the OFX file.
public struct Institute: Information {
static let label: String = "FI"

/// The name of the institution.
public var name: String = ""

/// An identifier for this specific institution.
public var id: Identifier = ""

init?(parent element: Element) {
if let element = element[Institute.label] {
name = element["ORG"]?.content ?? ""
id = element["FID"]?.content ?? ""
}
}
}

See: https://developer.apple.com/library/archive/qa/qa1480/_index.html
My fix: (I'm UK based & parsing Barclays Bank ofx files which use the date format 20191217000000[-5:EST]

let formatter = DateFormatter()
formatter.locale = Locale(identifier: "en_US_POSIX")
formatter.timeZone = TimeZone(secondsFromGMT: 0) // not sure if this is required - need to test
let maybeDate = formats.reduce(nil as Date?) { result, format in

When attempting to parse files with a hunded or more transactions significant amounts of memory used & parsing is extremely slow.

I fixed the problem in Element by using a computed property to remove whitespace on set

var _content: String = ""
var content: String {
get {
return _content
}
set (newValue){
_content = newValue.trimmingCharacters(in: .whitespacesAndNewlines)
}
}