sterc / seopro

The ultimate MODX Revolution SEO companion

SEOPro is now part of SEO Suite: https://github.com/sterc/seosuite

seopro's Issues

SEOPro doesn't seem to work in MODX 2.5.0-pl

Hello,

None of the great features of this extra are appearing when used with the new version of MODX.
Are you planning to release a new version ?

Sincerily
JeanClaude

seopro.fields doesn't support link_attributes

I'm trying to add link_attributes to the list of supported seopro.fields, however it doesn't seem to be supported (doesn't show the thumbs up/down panel above the field in the manager).

I've re-purposed this field for custom page titles that don't follow the site default as per the idea in #25

I'm using this setup in my page title:

[[*link_attributes:isempty=`[[*pagetitle:htmlentities]] | [[++site_seo_pagetitle:htmlentities:isempty=`[[++site_name:htmlentities]]`]]`]]

Is this by design?

Unable to save resource when longtitle or description is too long

I think this behavior changed in SEO Pro 1.2.2 pl: Add count back to pagetitle & longtitle.

This becomes problematic when updating SEO Pro on an existing site that contains resources with page- and longtitles beyond the limit. Users can't save these resources anymore now all of a sudden.

I would personally prefer to control this with a system setting. Strictly enforce character count: yes/no. There are other scenarios where you'd want to allow longer titles, for example when you import content or take over an old site for optimization.

Not seeing the Yandex emoticon

It's not a 404-image or something, it just isnt in the code, see screenshot.

Getting "thumb down" on Description field despite containing focus keywords.

Hi Sterc!

I'm receiving a strange behaviour. Perhaps it's a bug or maybe I'm not understanding how Focus Keywords works.

Note the thumbs down for the Description field in the following picture:

Now if I change "construction" to simply "construct" I get a thumbs up:

Is this the correct behaviour? If so, can someone please explain it to me?

Thanks!

Feature Request: System setting to contain default keywords for the site

This will automatically populate the keyword field on resources if nothing has manually been entered.

Wrong number of characters in pagetitle and introtext

with an empty value indicates the 33 characters instead of zero.

PrntScrn ---> http://prnt.sc/e0kzoy

In descrition is doing great

Unable to save a resource if the number of characters in a SEO Pro fields is larger than the default one

MODX 2.6.3

I upgrade to SEOPro 1.3.0, and now I am unable to save a resource if the number of characters in a SEO Pro fields is larger than the default one

Before the update I was able to save a resource when the number of characters was larger than the default one for the SEO Pro fields.

Is this normal, and should I change the default values for the SEO Pro fields?

Thank

Enable when creating new resource

Enable when creating a new resource if template field is equal to default template within system settings.

Branding

If i turn off the allow branding setting, my sitename is still inside the preview.

My MetaTager snippet now compabile with SEOPro

My MetaTager snippet now compabile with SEOPro.

I've added automatic output of seoKeywords in this commit
ershov-ilya/MetaTager@7aba5f9

keywords to placeholder

The keywords must be set to a placeholder.

Wrong character count when show site title in description is off

After setting the seopro.usesitename setting to NO, when editing a resource, the pagetitle/longtitle field total number of characters left, still reflects the site_name setting.

Field to override title+site_name

I'd like to have an addional text field below the keywords field that (if not empty) overrides the complete title (longtitle + delimiter + site_name) with it's value. (That would be creative freedom :P)

Uses cases are e.g.:

• the homepage could contain just the site_name or custom sentence
• or a landingpage could get a custom title without the site_name attached

Might be an easy job for a dev that is quicker with the extjs stuff...

Implement Flesch Reading Score

It would be really nice to show the Flesch Reading Ease Score metric in SEO Pro.

More info and formula: http://www.readabilityformulas.com/free-readability-formula-tests.php

Inherit settings for children

Don't think you can already set this but it would be a great feature to add to SEOPro - the ability for child resources to inherit parent settings especially useful if you have an area that you don't want to be listed in xml sitemap because they are in a "members" area.

[MODX 2.3] CSS Improvements

Hey guys! I just tested SEOPro in the latest MODX 2.3 version from github. There are some bugs you'll hopefully fix soon? (eg.: URL is missing in preview, keywords are not safed)

I'd like to share some CSS changes I made that might help you:

.seopro-panel{
    background-color: #fff;
    border: #e4e4e4 1px solid;
    border-radius: 2px;
    padding: 2px 3px;
}
.seopro-counter{
    position: absolute;
    z-index: 2;
    top: -22px;
    right: 0;
    text-align: right;
    font-size: 12px;
    line-height: 20px;
}
#seopro-google-title{
    color: #1A0DAB;
    font-size: 18px;
    white-space: nowrap;
    width: 520px;
    font-family: arial, sans-serif;
    text-overflow: ellipsis;
    overflow: hidden;
}

#seopro-google-url{
    color: #006621;
    margin-bottom: 1px;
}

#seopro-google-description{
    font-size: 13px;
    color: #545454;
    line-height: 1.4;
    word-wrap: break-word;
    font-family: arial, sans-serif;
}
.seopro-counter .green{
    color: #919191 !important;
}
.seopro-counter .red{
    color: #707070 !important;
}

.seopro-counter-chars.red {
    color: #D80000 !important;
}

I've added some styles from Googles current search result page, so the preview box is much more correct now.

Some of this changes won't work for MODX <2.3 so you'll need to add a switch or CSS class for the MODX version.

Here's a preview:

Warning into seoPro plugin

PHP notice: Undefined index: template
seoPro plugin, line 114
$template = ($modx->resource->get('template')) ? (string)$modx->resource->get('template') : (string)$_REQUEST['template'];
Version of seoPro: 1.0.4

Make google title suffix editable

A system setting where you could change the suffix for the title (currently site_name) would be a great feature. Same for the divider which could be included into the setting.

Problems with compiling

Please explain the specifications of compiling this package. I can't do this bacause of:

1. how deep need to be placed folder SEOPro from the root of site folder?
   In build script I found sting^
   $root = dirname(dirname(FILE)).'/';
   which means for me, need to put SEOPro in the root of MODX site to compile... but script can't find modx core
2. in script is string:
   require_once dirname(FILE) . '/build.config.php';
   but where is no such file... even in yours repository

Option to rename "301 Redirect" section to just "Redirects"

Today a client got very confused by the 301 Redirect section of this plugin, she literally was reading it like "three hundred and one redirects"; to keep things as client friendly as possible it would be to have an option to name the section just "Redirects"?

Maybe this could be managed in the SEOPro Lexicons?

Feature request: adjusting meta lengths to 2018 guide lines

Since 2018 Google changed the way they look at and display the length of meta data. The general assumption is that Google Search now displays up to 76 characters of the page title (70 is safe) and up to 325 in the description (300 is safe). You can adjust the amount of characters in SEO Pro, but the description field still displays a warning and the preview pane still truncates. It would be nice if it would support the new guide lines without having to hack anything.

Ability to disable SEOPro for specified resources

Some of my resources don't need SEOPro, for example I have a settings page that is just used for settings and not displayed on frontend. It would be great if we could disable SEOPro for certain resources, for example by means of a system setting where you could enter the IDs of the resources to be excluded.

Letter/Char counts are not updating in MODx 2.5.8

The letter/char count is not updating anymore for pagetitle and longtitle fields. It is still working in description fields.

This issue occured after updating to MODx 2.5.8 with SEOPro 1.2.1

Found not compatiblity with AjaxManager

Both SEOpro and SEOTeb Found not compatible with AjaxManager. They not rendering on load of another resource with AjaxManager...

TV to keyword Gist is missing?

the URL to the gist https://gist.github.com/hometownlegends/7751607 results in a 404.

Settings option to remove the Keywords section and Keyword Count

We love the Google Preview and word count, but the Keywords bit is very confusing to some clients. It would be awesome to have an option to remove that.

keywords not getting saved - bug?

Hi,
When my client creates a page and fills out the keywords (focus keywords) and then hits the save button. the keywords are NOT saved in MODX 2.2.14.
The sneaky bit is that because the page does not refresh it looks like the keywords are saved propery
Maybe this happens because there is no resource ID at the moment of first save

Undefined index: template

Is there any szenario where a frontend request (OnLoadWebDocuement) would contain a template param in the $_REQUEST array?

https://github.com/Sterc/SEOPro/blob/master/core/components/seopro/elements/plugins/seopro.plugin.php#L114

Array
(
    [content] => [2016-01-19 18:13:04] (WARN @ /core/cache/includes/elements/modplugin/2.include.cache.php : 114) PHP notice: Undefined index: template

    [level] => WARN
    [msg] => PHP notice: Undefined index: template
    [def] => 
    [file] =>  @ /core/cache/includes/elements/modplugin/2.include.cache.php
    [line] =>  : 114
)

Include keywords in search?

I would like to be able to include SEO focus keywords into SimpleSearch. But it isn't TV.

&includeTVs=`1`
&includeTVList=`seoPro.keywords`

Everytime a resource is opened many errors appear

This is in the log of 5 of my sites using SEOpro (MODXCloud, locahost and a client hosted one) all the same:

[2013-11-06 02:06:09] (ERROR @ /paas/c2248/www/core/xpdo/xpdo.class.php : 2374) PHP warning: json_encode(): recursion detected
[2013-11-06 02:06:09] (ERROR @ /paas/c2248/www/core/xpdo/xpdo.class.php : 2374) PHP warning: json_encode(): recursion detected
[2013-11-06 02:06:09] (ERROR @ /paas/c2248/www/core/xpdo/xpdo.class.php : 2374) PHP warning: json_encode(): recursion detected
[2013-11-06 02:06:09] (ERROR @ /paas/c2248/www/core/xpdo/xpdo.class.php : 2374) PHP warning: json_encode(): recursion detected
...You get the idea.....

SEO Pro does not work right as a package dependecy

I want to add this in my package, but this does not work, the download button does nothing in the dependencies tab.

$attr = array(
    'license' => file_get_contents($sources['docs'] . 'license.txt'),
    'readme' => file_get_contents($sources['docs'] . 'readme.txt'),
    'changelog' => file_get_contents($sources['docs'] . 'changelog.txt'),
    'requires' => array(
        'ace' => '>=1.6.4',
        'formit' => '>=2.2.8',
        'migx' => '>=2.9.6',
        'pdotools' => '>=2.1.20',
        'pthumb' => '>=2.3.3',
        'xrouting' => '>=1.4.1',
        'seopro' => '>=1.0.4'
    ),
);

This does not work either.

'SEO Pro' => '>=1.0.4',

Is the name SEOPro? SEO Pro or something else?
What sould I add to add SEO Pro as a dependecy?

Compatibility with Articles

Google preview is bad (no longtitle).

Add placeholder helptext for keywords

Add placeholder when hovering over keywords field.
[[+seoPro.keywords]]

Google Preview shows false information if you duplicate a resource

MODX 2.4, SeoPro 1.0.4

Google preview differs from actual Google display

Pagetitle will be used as SEO title if no longtitle present.

Actual site template can however differ from template used in SEOPro.

Would be great if the SEOPro rules could be adjusted.

Now SEOPro preview can really differ from actual data as displayed in search engines, depending on the used sitetemplate.

Error while creating resource from frontend

When resource is created from web context this:
https://github.com/Sterc/SEOPro/blob/master/core/components/seopro/elements/plugins/seopro.plugin.php#L71
yields to error "seoKeywords: Attempt to set NOT NULL field resource to NULL"

You should check if the document is created from manager to add keywords.

Localizations

Please put string "Vul uw META description." in lexicons too.
It using in Google snippet preview...

Use an existing TV for the Focus Keywords

We have TV set for extra page keywords using the Auto-Tag TV input type; it would be great if there were a system setting to use an existing TV for the focus keywords.

Content Key Word Check?

I love the SEOPro 3PC, but I've noticed an interesting habit. Customers are getting "Thumbs Up" on everything, but wondering why their pages aren't ranking. Further investigation is showing that they are not putting any of the keywords in the Content Area, which is by far the most important location.

Not sure if it's doable, but it would be nice to have some sort of indicator to show that the Content Area is also utilizing the keywords.

Preview changes (desktop/mobile difference)

There have been some changes in Google which has consequences for the Preview features in SEO Tab. Google SERP's show different in Mobile and Desktop search results

Mistakes when using Seopro

Hello! I faced some mistakes at Seopro's use
and addition popular in Russia - Tickets https://github.com/bezumkin/Tickets.
Mistakes are specified on screenshots...
Forgive for my Google translate...

[Enhancement] Create setting for excluding certain template ID's from using SEOpro

(I don't know if this is possible right now, sorry if I missed it..)

Although it's great to have on all your content-related resources, sometimes there's other types of resources that don't require the SEOpro plugin to be loaded. It would be nice if you could exclude those resources somehow. Think the best way is by template ID, but other options might also be relevant.

Alias error for homepage (friendly urls)

You get an error Cannot read property 'dom' of null when you are trying to save homepage with friendly urls turned on.

Reason
You are trying to render to an invalid div. Class seopro-replace-alias is not injected because alias can't be replaced as the string you search for doesn't exist. Full scheme url for homepage is actually without alias ;)
http://github.com/homepage -> http://github.com

This is from plugin:

$url = $modx->makeUrl($resource->get('id'), '', '', 'full');
$url = str_replace($resource->get('alias'), '<span id=\"seopro-replace-alias\">' . $resource->get('alias') . '</span>', $url);

MODX 2.3.3

Possible to remove the site's name from the title tag?

This is a really great MODX plugin I have been looking for quite a long time. Great work!

I see from the preview when creating a MODX resource that the site's name shows up in the SEO Title tags preview (see screenshot below). Is there any way to remove the site's name from the title tag as an option? Sometimes I don't want the name of the site in the SEO title tag.

Is it possible to set an option to show/hide the site's name in the title tag in the System Settings for seopro?

Question : Output values to placeholder, chunk or use plugin to addToHead

Output key seo values that seopro can generate so everyone can use seoPro.

Should we set placeholders, create a chunk or add all the data to head with a plugin?

Keyword Suggest

I still have a few pages that don't have keywords. They aren't really import for traffic, but my validation is nagging me to fix them. It would be nice to have a "keyword suggestion" button. To scan the content and insert into the keyword field.

Something like this...
Keyword Generator (Multibyte)
https://github.com/peterkahl/multibyte-keyword-generator/blob/master/src/KeywordGenerator.php

Sure some page are generated with a snippet and might not have any content to use.

Keywords not saved

When creating a new page there's a zero (0) in the field. When typing something else in the field and saving, the resource saves correctly, but the keywords are not saved. When I go back to the resource the zero appears again. So I cannot fill in the keywords.

Modx 2.6.1. / PHP 7.2 / SeoPro 1.2.2.

seopro.fields not working as context setting

I'm trying to override the seopro.fields setting for a specific context, but they're not being picked up.

Tried adding it under both core namespace and seopro. Haven't tried with other system settings.

Feature request: make description count available via setting ( < 300)

Google seems to allow >155 (<300) characters for the meta description. Would be great if we could adjust the thresholds (by using custom property sets?)