stefanpenner / ember-cli-addon-aware-resolver Goto Github PK

require('my-package')

should resolve to the main import (per my-package's package.json), or index.js if no main is specified

see #7

We only support:

• classic ember apps
• classic ember addons
• v2 ember addons

We assume a non-addon must be a classic ember app. In order to support "embroider v2" style apps, or non-ember dependencies, we would need a reliable way of detecting whether something is a classic ember app or a "standard" npm dependency.

Options:

• Assume everything is a standard npm dependency and accept another argument to indicate which is the classic ember app. This is possible because we don't expect there to be more than 1 classic ember app beyond the truly pathological cases (e.g. an addon depending on an app).
• Add something to package.json to identify that something is a classic ember app (ember-app keyword or similar)

see #7

Given apps

my-app/
  app/
    tests/
      foo.js


my-pathological-app/
  app/
    tests/
      bar.js
  tests/
    bar.js

The following

resolve('my-app/tests/foo.js', options) === `${pathToMyApp}/app/tests.foo.js`)

will not work as we assume tests/foo.js must be in tests

Similarly resolve('my-pathological-app/tests/foo.js', options) is ambiguous and probably requires the ember env to properly disambiguate.

Peer dependencies are installed by default in npm@7 and so are usable again.

• Update node-fixturify-project to support peer deps
• check peer-dependencies for addons
• dep > dev dep > peer dep for root
• ignore dev dep for addon
• dep > peer dep for addon