Coder Social home page Coder Social logo

Comments (9)

stefanpenner avatar stefanpenner commented on August 16, 2024

@joefiorini I can(or get someone) add it to our deployment automation tooling. My thoughts are to try and add all these "package management systems" to your deployment flow. We can likely automate most of it.

from ember-app-kit.

joefiorini avatar joefiorini commented on August 16, 2024

@stefanpenner The more I think about it, I'm wondering if we need the component.js repo. Rather than relying on keeping a third-party repo up-to-date, why not create our own ember-source repo that only contains the latest ember.js and ember-data.js? On every successful build we push to ember-source and keep semver tags for every release. I realize it's duplicating the responsibility of http://builds.emberjs.com, but it would play very nicely with bower, since we can't install from S3. What do you think?

from ember-app-kit.

joefiorini avatar joefiorini commented on August 16, 2024

Okay, I think I just unknowingly lied a little. Apparently bower DOES pull from S3; setting:

"ember": "http://builds.emberjs.com/ember-latest.js"

actually pulled the latest build and used the e-tag as version string. Interesting. I wonder if that means we could control dependencies by pushing a bower.json to S3 as well?

from ember-app-kit.

rwjblue avatar rwjblue commented on August 16, 2024

Looks like the components/ember PR was accepted, but it had issues. It required handlebars 1.0.0 instead of 1.0.0-rc.4. I just submitted another PR to the components/ember repo (here) to resolve the issue.

from ember-app-kit.

rwjblue avatar rwjblue commented on August 16, 2024

@joefiorini - That's great! We could just use the normal Ember publishing process, and link directly to the 'stable' version in bower.json. Like so (we can't use ember-latest.js as you described above to future proof since that points to master):

{
  "name": "ember-app-kit",
  "dependencies": {
    "ember": "http://builds.emberjs.com/ember-1.0.0-rc.6.1.js",
    "handlebars": "1.0.0-rc.4",
    "jquery": "~1.9.1"
  }
}

The only (small) downside is that it then names the file vendor/ember/index.js, but that isn't a huge issue.

If we do this, we can just get rid of the reliance on the components/ember repo, and not add more work to the current publishing process.

I'll work up a PR for this change.

from ember-app-kit.

stefanpenner avatar stefanpenner commented on August 16, 2024

we seem to be 6.1 now.

from ember-app-kit.

rwjblue avatar rwjblue commented on August 16, 2024

It was updated in #60, but this issue didn't get closed auto_magic_ally...

from ember-app-kit.

joefiorini avatar joefiorini commented on August 16, 2024

@rjackson So last week it looked like there was a bower.json on S3, but now it's gone. Do you have any idea what might have happened? Maybe @stefanpenner knows?

from ember-app-kit.

rwjblue avatar rwjblue commented on August 16, 2024

@joefiorini - I recently spoke with @wycats and he indicated that he would like to have better bower support, so maybe the team would be open to getting a bower.json generated as part of the publish process.

Background: I have been working on an update to ember-dev that will generate the various files (ember.js, ember.min.js, ember.prod.js) into subdirectories. See emberjs/ember-dev#24 for more details.

I think that we might be able to generate a bower.json into the specific sub-directory which would allow us to use builds.emberjs.com/latest/bower.json or builds.emberjs.com/stable/bower.js and then let bower deal with the updated versioning and whatnot.

I think that we need to have a bower.json template included in the repo (or generated by the build process), and just update the version tag for the specific commit. Once emberjs/ember-dev#24 is merged we can look at outputting the right values.

from ember-app-kit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.