The async-promise-queue from stefanpenner

async-promise-queue's People

Contributors

Stargazers

Watchers

async-promise-queue's Issues

Update "async" dependency

async-promise-queue is currently using async@^2.4.1 which has a known Prototype Pollution vulnerability

async@^3.2.2 addresses this vulnerability

Additional information:
NVD: https://nvd.nist.gov/vuln/detail/CVE-2021-43138
Snyk: https://security.snyk.io/vuln/SNYK-JS-ASYNC-2441827

Fix async 2.6.4 compability

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Here is the diff that solved my problem:

Build Error (broccoli-persistent-filter:Babel > [Babel: @ember/test-helpers])

Cannot assign to read only property 'drain' of object '#<Object>'


Stack Trace and Error Report: /var/folders/5s/1y9hqll10z37zpn907glnh0c0000gn/T/error.dump.6af4450e13b7a860ed6da3733b67de52.log

diff --git a/node_modules/async-promise-queue/index.js b/node_modules/async-promise-queue/index.js
index 962c645..29f4bd5 100644
--- a/node_modules/async-promise-queue/index.js
+++ b/node_modules/async-promise-queue/index.js
@@ -10,8 +10,8 @@ module.exports = function queue(worker, work, concurrency) {
     } else {
       var q = require('async').queue(worker, concurrency);
       var firstError;
-      q.drain = resolve;
-      q.error = function(error) {
+      q.drain(resolve);
+      q.error(function(error) {
         if (firstError === undefined) {
           // only reject with the first error;
           firstError = error;
@@ -25,7 +25,7 @@ module.exports = function queue(worker, work, concurrency) {
           reject(firstError);
         };
 
-      };
+      });
       q.push(work);
     }
   });